Skip to content

Disable PyTorch Compile Multiprocessing #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ryantwolf merged 6 commits into from
Apr 22, 2024
Merged

Disable PyTorch Compile Multiprocessing #34

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
26790ac
Move tokenizer import
ryantwolf Apr 12, 2024
c4ff332
Reduce inductor threads
ryantwolf Apr 17, 2024
aa36931
Change env int to string
ryantwolf Apr 17, 2024
3592977
Change location of env var
ryantwolf Apr 17, 2024
8ed98fe
Merge branch 'main' into rywolf/nemo-import
ryantwolf Apr 19, 2024
af800eb
Add comment linking issue
ryantwolf Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion nemo_curator/filters/code.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,6 @@
import numpy as np
from bs4 import BeautifulSoup
from comment_parser import comment_parser
from nemo.collections.common.tokenizers import SentencePieceTokenizer

from nemo_curator.filters.doc_filter import DocumentFilter, import_filter
from nemo_curator.utils.constants import regex_alpha, regex_alphanum
Expand Down Expand Up @@ -104,6 +103,8 @@ def keep_document(self, score):
class TokenizerFertilityFilter(DocumentFilter):

def __init__(self, path_to_tokenizer=None, min_char_to_token_ratio=2.5):
from nemo.collections.common.tokenizers import SentencePieceTokenizer

if path_to_tokenizer is None:
raise ValueError(
"Must provide a valid path to a SentencePiece " "tokenizer"
Expand Down
7 changes: 7 additions & 0 deletions nemo_curator/modules/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,13 @@
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
import os

Comment thread
ryantwolf marked this conversation as resolved.
# Disables multiprocessing in torch.compile calls.
# Without this, Dasks multiprocessing combined with PyTorch's
# gives errors like "daemonic processes are not allowed to have children"
# See https://github.com/NVIDIA/NeMo-Curator/issues/31
os.environ["TORCHINDUCTOR_COMPILE_THREADS"] = "1"

from .add_id import AddId
from .exact_dedup import ExactDuplicates
Expand Down