docs: update semdedup docs for vLLM default backend (PR #1606) - #1659
Merged
Conversation
praateekmahajan
approved these changes
Apr 2, 2026
Combine vLLM default backend release notes and breaking changes from this PR with Cosmos-Xenna, Workflow Results API, bug fixes, and other breaking changes from upstream. Use upstream's more detailed result.metadata comments in semdedup code examples. Signed-off-by: Logan Lane <llane@nvidia.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Lawrence Lane <llane@nvidia.com>
Comment on lines
+117
to
+120
| <<<<<<< HEAD | ||
| ======= | ||
| # result.metadata contains: total_time, num_duplicates, kmeans_time, pairwise_time | ||
| >>>>>>> upstream/26.04-staging |
Contributor
There was a problem hiding this comment.
Unresolved git merge conflict markers
Lines 117–120 contain raw <<<<<<< HEAD, =======, and >>>>>>> upstream/26.04-staging markers. These were not resolved before committing and will cause the Fern documentation build to fail or render the conflict markers verbatim to users.
The upstream side of the conflict contains a useful comment that should be retained:
Suggested change
| <<<<<<< HEAD | |
| ======= | |
| # result.metadata contains: total_time, num_duplicates, kmeans_time, pairwise_time | |
| >>>>>>> upstream/26.04-staging | |
| # result.metadata contains: total_time, num_duplicates, kmeans_time, pairwise_time |
Resolve leftover conflict markers that were missed in the previous merge resolution commit. Signed-off-by: Logan Lane <llane@nvidia.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Lawrence Lane <llane@nvidia.com>
Include both the vLLM default backend entry from this PR and the multi-user metrics isolation entry that landed via PR NVIDIA-NeMo#1656. Signed-off-by: Logan Lane <llane@nvidia.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Lawrence Lane <llane@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Updates v26.04 fern documentation to reflect the vLLM default embedding backend change from #1606. Replaces all
EmbeddingCreatorStagereferences withVLLMEmbeddingModelStage, updates the default model fromsentence-transformers/all-MiniLM-L6-v2togoogle/embeddinggemma-300m, removes stale parameters (embedding_max_seq_length,embedding_padding_side,embedding_pooling,embedding_model_inference_batch_size), and adds new vLLM-specific parameters (embedding_pretokenize,embedding_vllm_init_kwargs,model_cache_dir). Replaces the 26.02 release notes with a 26.04 skeleton including the vLLM default entry and breaking changes.Usage
Checklist