-
Notifications
You must be signed in to change notification settings - Fork 320
feat(interleaved): Foundation IO improvements — schema utilities, base-class fixes, and bug fixes #1652
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
VibhuJawa
merged 18 commits into
NVIDIA-NeMo:main
from
VibhuJawa:feat/interleaved-io-foundation
Apr 1, 2026
Merged
feat(interleaved): Foundation IO improvements — schema utilities, base-class fixes, and bug fixes #1652
Changes from all commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
34d2f34
feat(interleaved): foundation IO improvements — schema utilities, bas…
VibhuJawa 7702bfd
simplify(interleaved): move resolve_schema to shared utils, remove de…
VibhuJawa a1eeccc
Merge remote-tracking branch 'origin/main' into feat/interleaved-io-f…
VibhuJawa 33088b1
chore: remove unrelated nixl-cu12 from override-dependencies
VibhuJawa 6f0e655
chore: restore nixl-cu12 override-dependency
VibhuJawa 57263df
Remove source_id_field from WebDataset reader
VibhuJawa 27cc69a
simplify: fix align_table, type hints, and add dict-type comment
VibhuJawa 987f5d4
fix(tutorial): update quickstart notebook and set source_files in rea…
VibhuJawa 575e505
Apply suggestion from @claude[bot]
VibhuJawa 7df12f3
ci: update secrets baseline for notebook image outputs (false positives)
VibhuJawa 1a4dce4
fix: make source_files unique per split in webdataset reader
VibhuJawa 472b21c
fix: source_files per split lists only contributing tars in webdatase…
VibhuJawa be9e7c5
fix: source_files per split lists only contributing tars in webdatase…
VibhuJawa 86de41b
test: add schema_utils tests and expand interleaved coverage
VibhuJawa 9c35387
Merge remote-tracking branch 'origin/main' into feat/interleaved-io-f…
VibhuJawa 802ab23
Merge branch 'main' into feat/interleaved-io-foundation
VibhuJawa 5a82f0e
feat: add interleaved_cpu to all extras in pyproject.toml
VibhuJawa 54d1378
Merge branch 'main' into feat/interleaved-io-foundation
VibhuJawa File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this change will affect pdf PR too. Why was this removed? Is the reading happening via schema now ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just removed it , because it was excessive to have around. It now is just a passthrough column and not given special treatment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think if you remove it and its in the dataset, it will just work. Happy to help with your PR too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will revisit this discussion in 1657