Llane/release notes 26.02 audit fixes - #1519
Closed
lbliii wants to merge 103 commits into
Closed
Conversation
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Co-authored-by: Praateek Mahajan <praateekmahajan@users.noreply.github.com> Signed-off-by: L.B. <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: L.B. <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Signed-off-by: Lawrence Lane <llane@nvidia.com>
…NVIDIA-NeMo#1470) * Refactor stage names and update paths in configuration files Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * Fix processing logic to handle None results in ProcessingStage Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * Refactor stage classes to propagate names from constructors and remove hardcoded names Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * Fuse document iterate and extract stages (NVIDIA-NeMo#1458) * Fuse document iterate and extract stages Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * ruff Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * fix bug Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * update docs and tutorial Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * save progress Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * update more tests Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * ruff Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * fix tests Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * ruff Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * update benchmark Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * move class Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * add missing import Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> * update comment Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> --------- Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * Llane/sdg ray docs (NVIDIA-NeMo#1347) * sdg ray docs init Signed-off-by: Lawrence Lane <llane@nvidia.com> * header, tab fixes Signed-off-by: Lawrence Lane <llane@nvidia.com> * style guide Signed-off-by: Lawrence Lane <llane@nvidia.com> * release notes change, bump version Signed-off-by: Lawrence Lane <llane@nvidia.com> * feedback Signed-off-by: Lawrence Lane <llane@nvidia.com> * readme Signed-off-by: Lawrence Lane <llane@nvidia.com> * updates Signed-off-by: Lawrence Lane <llane@nvidia.com> * updates Signed-off-by: Lawrence Lane <llane@nvidia.com> * updates Signed-off-by: Lawrence Lane <llane@nvidia.com> * updates Signed-off-by: Lawrence Lane <llane@nvidia.com> * Update tutorials/synthetic/README.md Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> --------- Signed-off-by: Lawrence Lane <llane@nvidia.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * ci: Remove thirdparty aiohttp file from ray (NVIDIA-NeMo#1469) Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * refactor: Enhance stage classes to propagate performance metrics and set stage names Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * fixes as per greptile Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * fixes as per greptile Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * remove continue part Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> * Update nemo_curator/stages/audio/common.py Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> --------- Signed-off-by: SwekeR-463 <swekerswasti@gmail.com> Signed-off-by: Sarah Yurick <sarahyurick@gmail.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com> Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com> Co-authored-by: Lawrence Lane <llane@nvidia.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Dong Hyuk Chang <thomaschang26@tutanota.com>
* first commit * initial commit - workable * fix lint * fix lint * addressing comments, tested * fix lint * update uv lock * fix greptile suggestion * addressing comments * lint * greptile fix * lint * addressing comments * fix lint * update uv lock with putest_server * resolve uv lock * restore uv.lock * addressing comment * ndd benchmark * update uv.lock * udpate benchmarking * adding num_input_chars, num_output_chars to metrics * lint * addressing comments * fix bug * lint * lin * lint * fix import * fix .github/workflows/cicd-main.yml --------- Co-authored-by: Huy Vu2 <huvu@login-eos02.eos.clusters.nvidia.com>
NVIDIA-NeMo#1452) * [benchmark] Add FastText filter benchmarking script (NVIDIA-NeMo#1411) - Add fasttext_filter_benchmark.py script following the pattern from score_filter_benchmark.py - Add fasttext_filter_raydata and fasttext_filter_xenna entries to nightly-benchmark.yaml - Supports FastText language ID and quality filters with model setup requirements Fixes NVIDIA-NeMo#1411 Signed-off-by: Kunal Sachdev <kunalmgsachdev@gmail.com> * [benchmark] Wire FastText model paths explicitly and update nightly config (NVIDIA-NeMo#1411) - Add separate dataset entries for FastText langid and quality models - Pass FastText model paths as explicit CLI arguments to benchmarks - Remove hardcoded model paths from Hydra overrides - Update FastText filter benchmarks to use model_weights_path - Align arxiv E2E benchmark arg naming with FastText langid usage Signed-off-by: Kunal Sachdev <kunalmgsachdev@gmail.com> * Updated fasttext_filter_raydata benchmark timeout in benchmarking/nightly-benchmark.yaml basis Sarah Yurick's test run (NVIDIA-NeMo#1411) Signed-off-by: Kunal Sachdev <kunalmgsachdev@gmail.com> * Updated fasttext_filter_xenna benchmark timeout in benchmarking/nightly-benchmark.yaml basis Sarah Yurick's test run (NVIDIA-NeMo#1411) Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Kunal Sachdev <kunalmgsachdev@gmail.com> * Updated fasttext_quality_model dataset entry's model file name to model.bin in benchmarking/nightly-benchmark.yaml (NVIDIA-NeMo#1411) Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Kunal Sachdev <kunalmgsachdev@gmail.com> * Adding ftz file option for fasttext_langid_model datasets entry in benchmarking/nightly-benchmark.yaml (NVIDIA-NeMo#1411) Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Kunal Sachdev <kunalmgsachdev@gmail.com> * Moving fasttext_filter_raydata and fasttext_filter_xenna to run right after ScoreFilter benchmarks in benchmarking/nightly-benchmark.yaml (NVIDIA-NeMo#1411) Signed-off-by: Kunal Sachdev <kunalmgsachdev@gmail.com> --------- Signed-off-by: Kunal Sachdev <kunalmgsachdev@gmail.com> Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>
) (NVIDIA-NeMo#1507) Signed-off-by: Arivunidhi A <arivunidhi.a@gmail.com> Co-authored-by: Arivunidhi A <arivunidhi.a@gmail.com> Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>
…ck (NVIDIA-NeMo#1511) * Refactor video frame extraction to improve PyNvCodec availability check - Removed the try-except block for importing PyNvcFrameExtractor, simplifying the import logic. - Updated the condition for initializing the PyNvcFrameExtractor in the VideoFrameExtractionStage to rely solely on the _PYNVC_AVAILABLE flag. - Adjusted the handling of pixel format conversion in NvVideoDecoder to prepare for future updates to cvcuda. Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> * Refactor NvVideoDecoder to replace deprecated nvcv_image with cvcuda tensor - Updated NvVideoDecoder to remove the use of nvcv_image, which is deprecated, and replaced it with cvcuda tensor. - Adjusted related tensor operations and tests to ensure compatibility with the new cvcuda implementation. Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> * Update import statements in test_nvcodec_utils.py to include ruff linting rule - Modified import statements in the test file to include the RUF100 linting rule, ensuring better adherence to coding standards. - This change enhances the clarity of the import handling tests. Signed-off-by: [Your Name] <your.email@example.com> Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> * Update tests/utils/test_nvcodec_utils.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> * Update tests/utils/test_nvcodec_utils.py Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> --------- Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> Signed-off-by: [Your Name] <your.email@example.com> Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com> Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com>
* add model weights Signed-off-by: Vibhu Jawa <vjawa@nvidia.com> * address validation feedback Signed-off-by: Vibhu Jawa <vjawa@nvidia.com> --------- Signed-off-by: Vibhu Jawa <vjawa@nvidia.com> Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com>
… are specified (NVIDIA-NeMo#1508) * Warn and resolve conflict when both blocksize and files_per_partition are specified (NVIDIA-NeMo#1401) Signed-off-by: Arivunidhi A <arivunidhi.a@gmail.com> * Add warning assertion to test_both_blocksize_and_files_per_partition_warns Address review feedback: verify that the warning message is actually logged when both blocksize and files_per_partition are specified, using caplog fixture consistent with existing test patterns. --------- Signed-off-by: Arivunidhi A <arivunidhi.a@gmail.com> Co-authored-by: Arivunidhi A <arivunidhi.a@gmail.com>
- Fix YAML config example to use correct Hydra CLI (--config-path, --config-name) - Correct image curation batch sizes to match source (dali_batch_size=100, num_threads=8) - Update code linting claim to Ruff (markdownlint not in pre-commit) - Remove unverifiable Ray Actor Pool progress bars and small cluster warnings Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Lawrence Lane <llane@nvidia.com>
lbliii
force-pushed
the
llane/release-notes-26.02-audit-fixes
branch
from
February 18, 2026 18:05
1a65eba to
488c3d3
Compare
Contributor
Greptile SummaryThis PR consolidates the 26.02 release documentation by adding a concise CHANGELOG entry and streamlining the verbose release notes. The changes include:
The edits follow a consistent editorial direction toward more concise documentation. All formatting is correct, and the command examples are consistent with existing documentation. Confidence Score: 5/5
Important Files Changed
Last reviewed commit: 3c11c07 |
- Fix YAML config example to use correct Hydra CLI (--config-path, --config-name) - Correct image curation batch sizes to match source (dali_batch_size=100, num_threads=8) - Update code linting claim to Ruff (markdownlint not in pre-commit) - Remove unverifiable Ray Actor Pool progress bars and small cluster warnings Co-authored-by: Cursor <cursoragent@cursor.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> Co-authored-by: Cursor <cursoragent@cursor.com>
…b.com/lbliii/NeMo-Curator into llane/release-notes-26.02-audit-fixes
sarahyurick
requested changes
Feb 19, 2026
sarahyurick
left a comment
Contributor
There was a problem hiding this comment.
Please update the PR to target r1.1.0 instead of main.
ayushdg
reviewed
Feb 19, 2026
Signed-off-by: Lawrence Lane <llane@nvidia.com>
Contributor
|
Closing in favor of #1529. |
abhinavg4
requested changes
Feb 19, 2026
| - **End-to-End Pipeline Benchmarking**: Automated benchmarks for all curation modalities (text, image, video, audio) | ||
| - **Performance Tracking**: Integration with MLflow for metrics tracking and Slack for notifications | ||
| - **Nightly Benchmarks**: Continuous performance monitoring across: | ||
| - **Stage and Pipeline Benchmarking**: Automated benchmarks for curation modalities (text, image, video, audio) |
| - Text pipelines: exact deduplication, fuzzy deduplication, semantic deduplication, score filters, modifiers | ||
| - Image curation workflows with DALI-based processing | ||
| - Video processing pipelines with scene detection and semantic deduplication | ||
| - Audio ASR inference and quality assessment |
| - **Performance Tracking**: Metrics tracking across: | ||
| - Text pipelines: exact deduplication, fuzzy deduplication, semantic deduplication, score filters, modifiers | ||
| - Image curation workflows with DALI-based processing | ||
| - Video processing pipelines with scene detection and semantic deduplication |
Contributor
There was a problem hiding this comment.
Can we add captioning here?
Video processing pipelines with splitting, scene detection, and captioning.
| ### Image Curation | ||
|
|
||
| - **Optimized Batch Sizes**: Reduced default batch sizes for better CPU memory usage (batch_size=50, num_threads=4) | ||
| - **Optimized Batch Sizes**: Configurable batch sizes for better CPU/GPU memory usage (batch_size=100, num_threads=8) |
Contributor
There was a problem hiding this comment.
num_threds is 16 I think
|
|
||
| - **Video**: Removed InternVideo2; vLLM 0.14.1, FFmpeg 8.0.1 | ||
| - **Audio**: Enhanced ASR/WER docs, robust manifest handling | ||
| - **Image**: Optimized batch sizes (batch_size=100, num_threads=8), memory guidance |
|
|
||
| ### Improvements | ||
|
|
||
| - **Video**: Removed InternVideo2; vLLM 0.14.1, FFmpeg 8.0.1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.