Skip to content

cp: Update tutorial to be more explicit about num_gpus (#1492) #1499

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
thomasdhc merged 1 commit into from
Feb 12, 2026
Merged

cp: Update tutorial to be more explicit about num_gpus (#1492) #1499

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 10 additions & 2 deletions tutorials/text/deduplication/fuzzy/fuzzy_e2e.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -267,10 +267,18 @@
"source": [
"import time\n",
"\n",
"import torch\n",
"\n",
"from nemo_curator.backends.experimental.ray_data import RayDataExecutor\n",
"from nemo_curator.core.client import RayClient\n",
"\n",
"client = RayClient(num_cpus=64, num_gpus=2) # change as needed\n",
"NUM_GPUS = 2\n",
"\n",

@greptile-apps greptile-apps Bot Feb 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar: "are lesser" should be "is less" or "are fewer"

Suggested change
"\n",
error_msg = "The number of GPUs on this machine is less than the default this tutorial was tested with, please update `num_gpus` passed into `RayClient`"

"if torch.cuda.device_count() < NUM_GPUS:\n",
" error_msg = \"The number of GPUs on this machine are lesser than the default this tutorial was tested with, please update `num_gpus` passed into `RayClient`\"\n",
" raise ValueError(error_msg)\n",
"\n",
"client = RayClient(num_cpus=64, num_gpus=NUM_GPUS) # change as needed\n",
"client.start()"
]
},
Expand Down Expand Up @@ -1501,7 +1509,7 @@
"name": "python",
"nbconvert_exporter": "python",
"pygments_lexer": "ipython3",
"version": "3.12.3"
"version": "3.12.11"
}
},
"nbformat": 4,
Expand Down
12 changes: 10 additions & 2 deletions tutorials/text/deduplication/semantic/semantic_e2e.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -253,10 +253,18 @@
}
],
"source": [
"import torch\n",
"\n",
"from nemo_curator.core.client import RayClient\n",
"\n",
"# Number of GPUs should be roughly 2x the memory of the embeddings\n",
"client = RayClient(num_cpus=64, num_gpus=4)\n",
"NUM_GPUS = 4\n",
"\n",

@greptile-apps greptile-apps Bot Feb 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar: "are lesser" should be "is less" or "are fewer"

Suggested change
"\n",
error_msg = "The number of GPUs on this machine is less than the default this tutorial was tested with, please update `num_gpus` passed into `RayClient`"

"if torch.cuda.device_count() < NUM_GPUS:\n",
" error_msg = \"The number of GPUs on this machine are lesser than the default this tutorial was tested with, please update `num_gpus` passed into `RayClient`\"\n",
" raise ValueError(error_msg)\n",
"\n",
"client = RayClient(num_cpus=64, num_gpus=NUM_GPUS)\n",
"client.start()\n",
"try:\n",
" workflow.run()\n",
Expand Down Expand Up @@ -994,7 +1002,7 @@
],
"metadata": {
"kernelspec": {
"display_name": "Python 3",
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
Expand Down
12 changes: 10 additions & 2 deletions tutorials/text/deduplication/semantic/semantic_step_by_step.ipynb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,10 +122,18 @@
"metadata": {},
"outputs": [],
"source": [
"import torch\n",
"\n",
"from nemo_curator.core.client import RayClient\n",
"\n",
"# Number of GPUs should be roughly 2x the memory of the embeddings\n",
"client = RayClient(num_cpus=64, num_gpus=4)\n",
"NUM_GPUS = 4\n",

@greptile-apps greptile-apps Bot Feb 12, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammar: "are lesser" should be "is less" or "are fewer"

Suggested change
"NUM_GPUS = 4\n",
error_msg = "The number of GPUs on this machine is less than the default this tutorial was tested with, please update `num_gpus` passed into `RayClient`"

"\n",
"if torch.cuda.device_count() < NUM_GPUS:\n",
" error_msg = \"The number of GPUs on this machine are lesser than the default this tutorial was tested with, please update `num_gpus` passed into `RayClient`\"\n",
" raise ValueError(error_msg)\n",
"\n",
"client = RayClient(num_cpus=64, num_gpus=NUM_GPUS)\n",
"client.start()"
]
},
Expand Down Expand Up @@ -1142,7 +1150,7 @@
],
"metadata": {
"kernelspec": {
"display_name": "Python 3",
"display_name": "Python 3 (ipykernel)",
"language": "python",
"name": "python3"
},
Expand Down
Loading