Add check to make sure all reserved keywords are attributes and not properties by omkar-334 · Pull Request #1490 · NVIDIA-NeMo/Curator

omkar-334 · 2026-02-11T18:31:49Z

closes #1481

copy-pr-bot · 2026-02-11T18:31:52Z

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

greptile-apps · 2026-02-11T18:35:13Z

Greptile Overview

Greptile Summary

This PR adds validation to ensure that the reserved keywords (name, resources, batch_size) are not defined as @property decorators in ProcessingStage subclasses. This is necessary because the with_() method (lines 259-284 in base.py) directly assigns to these attributes to override configuration, which would fail if they were read-only properties.

Changes:

Added validation loop in __init_subclass__ (base.py:115-122) that raises TypeError if any of the three reserved keywords are defined as properties
Fixed existing violations by converting @property def name() to plain class attributes in BaseSyntheticStage, DiverseQAPostProcessingStage, and KnowledgeListPostProcessingStage
Added three new tests to verify the validation works for all three reserved keywords

The implementation is clean, well-tested, and includes helpful error messages that guide developers to use plain attributes or dataclass fields instead of properties.

Confidence Score: 5/5

This PR is safe to merge with minimal risk
The implementation is straightforward and addresses a real issue where @property decorators prevented the with_() method from working correctly. The changes include comprehensive test coverage, fix all existing violations in the codebase, and use a clear error message to guide developers
No files require special attention

Important Files Changed

Filename	Overview
nemo_curator/stages/base.py	Added validation in `__init_subclass__` to prevent reserved keywords (`name`, `resources`, `batch_size`) from being defined as `@property` decorators, ensuring `with_()` can override them
nemo_curator/stages/synthetic/nemotron_cc/base.py	Converted `name` from `@property` to plain class attribute to comply with new validation requirements
nemo_curator/stages/synthetic/nemotron_cc/nemotron_cc.py	Converted `name` from `@property` to plain class attribute in `DiverseQAPostProcessingStage` and `KnowledgeListPostProcessingStage`
tests/stages/common/test_base.py	Added comprehensive test coverage for the new validation that prevents `name`, `resources`, and `batch_size` from being defined as `@property` decorators

greptile-apps

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

greptile-apps

_{3 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: Omkar Kabde <omkarkabde@gmail.com>

NVIDIA-NeMo#1471) * Update transformers dependency to exact version 4.55.2 in pyproject.toml and uv.lock to prevent import failures in Cosmos Embed. Downgrade tokenizers version to 0.21.4 for compatibility. Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> * Update transformers dependency in pyproject.toml and uv.lock to allow versions up to 4.55.2, ensuring compatibility with Cosmos Embed imports. Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> --------- Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: Omkar Kabde <omkarkabde@gmail.com>

Signed-off-by: Omkar Kabde <omkarkabde@gmail.com>

* docs: vdr feedback Signed-off-by: Lawrence Lane <llane@nvidia.com> * Update docs/admin/installation.md Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> * Update docs/admin/installation.md Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> * Update docs/admin/installation.md Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> * Update docs/curate-text/process-data/quality-assessment/distributed-classifier.md Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> * feedback Signed-off-by: Lawrence Lane <llane@nvidia.com> * feedback Signed-off-by: Lawrence Lane <llane@nvidia.com> * re order sidebar Signed-off-by: Lawrence Lane <llane@nvidia.com> * release notes draft Signed-off-by: Lawrence Lane <llane@nvidia.com> * feedback Signed-off-by: Lawrence Lane <llane@nvidia.com> * remove more internvid content Signed-off-by: Lawrence Lane <llane@nvidia.com> * release note fix Signed-off-by: Lawrence Lane <llane@nvidia.com> * Update docs/curate-video/tutorials/split-dedup.md Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> --------- Signed-off-by: Lawrence Lane <llane@nvidia.com> Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Omkar Kabde <omkarkabde@gmail.com>

omkar-334 · 2026-02-11T19:47:08Z

The commits got messed up while rebasing and signing the commits I guess..

greptile-apps

_{4 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

sarahyurick · 2026-02-11T20:06:21Z

+                def process(self, task: MockTask) -> MockTask:
+                    return task
+
+    def test_plain_attribute_override_allowed(self):


I think this may not be needed and should already be covered by TestProcessingStageWith which uses ConcreteProcessingStage. What do you think @omkar-334 ?

You're right... TestProcessingStageWith already tests for attribute overrides. Thanks for this!. Ive removed it now

Signed-off-by: Omkar Kabde <omkarkabde@gmail.com>

… fix-property

greptile-apps

_{4 files reviewed, no comments}

_{Edit Code Review Agent Settings | Greptile}

sarahyurick · 2026-02-11T23:09:31Z

/ok to test ba29581

sarahyurick

Thanks @omkar-334 for the quick response!

…roperties (NVIDIA-NeMo#1490) * Fix: fasttext predict call for numpy>2 (NVIDIA-NeMo#1482) Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: Omkar Kabde <omkarkabde@gmail.com> * Update transformers dependency to exact version 4.55.2 in pyproject.t… (NVIDIA-NeMo#1471) * Update transformers dependency to exact version 4.55.2 in pyproject.toml and uv.lock to prevent import failures in Cosmos Embed. Downgrade tokenizers version to 0.21.4 for compatibility. Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> * Update transformers dependency in pyproject.toml and uv.lock to allow versions up to 4.55.2, ensuring compatibility with Cosmos Embed imports. Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> --------- Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: Omkar Kabde <omkarkabde@gmail.com> * remove property and add check Signed-off-by: Omkar Kabde <omkarkabde@gmail.com> * add tests Signed-off-by: Omkar Kabde <omkarkabde@gmail.com> * docs: vdr feedback (NVIDIA-NeMo#1477) * docs: vdr feedback Signed-off-by: Lawrence Lane <llane@nvidia.com> * Update docs/admin/installation.md Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> * Update docs/admin/installation.md Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> * Update docs/admin/installation.md Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> * Update docs/curate-text/process-data/quality-assessment/distributed-classifier.md Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Lawrence Lane <llane@nvidia.com> * feedback Signed-off-by: Lawrence Lane <llane@nvidia.com> * feedback Signed-off-by: Lawrence Lane <llane@nvidia.com> * re order sidebar Signed-off-by: Lawrence Lane <llane@nvidia.com> * release notes draft Signed-off-by: Lawrence Lane <llane@nvidia.com> * feedback Signed-off-by: Lawrence Lane <llane@nvidia.com> * remove more internvid content Signed-off-by: Lawrence Lane <llane@nvidia.com> * release note fix Signed-off-by: Lawrence Lane <llane@nvidia.com> * Update docs/curate-video/tutorials/split-dedup.md Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> --------- Signed-off-by: Lawrence Lane <llane@nvidia.com> Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Omkar Kabde <omkarkabde@gmail.com> * remove override test Signed-off-by: Omkar Kabde <omkarkabde@gmail.com> --------- Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: Omkar Kabde <omkarkabde@gmail.com> Signed-off-by: Abhinav Garg <abhinavg@stanford.edu> Signed-off-by: Lawrence Lane <llane@nvidia.com> Signed-off-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Co-authored-by: Ayush Dattagupta <ayushdg95@gmail.com> Co-authored-by: Abhinav Garg <abhinavg@stanford.edu> Co-authored-by: Lawrence Lane <llane@nvidia.com> Co-authored-by: Sarah Yurick <53962159+sarahyurick@users.noreply.github.com> Signed-off-by: Omkar Kabde <omkarkabde@gmail.com>

github-actions Bot added the community-request label Feb 11, 2026

omkar-334 force-pushed the fix-property branch from 27dc156 to 4ed506b Compare February 11, 2026 18:32

greptile-apps Bot reviewed Feb 11, 2026

View reviewed changes

sarahyurick reviewed Feb 11, 2026

View reviewed changes

Comment thread nemo_curator/stages/base.py

greptile-apps Bot reviewed Feb 11, 2026

View reviewed changes

ayushdg and others added 5 commits February 12, 2026 01:15

Fix: fasttext predict call for numpy>2 (NVIDIA-NeMo#1482)

bb3c712

Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com> Signed-off-by: Omkar Kabde <omkarkabde@gmail.com>

remove property and add check

e715aba

Signed-off-by: Omkar Kabde <omkarkabde@gmail.com>

add tests

d0ab998

Signed-off-by: Omkar Kabde <omkarkabde@gmail.com>

omkar-334 force-pushed the fix-property branch from 53b4266 to ac5b0e1 Compare February 11, 2026 19:45

Merge branch 'main' into fix-property

bca3d0e

greptile-apps Bot reviewed Feb 11, 2026

View reviewed changes

sarahyurick reviewed Feb 11, 2026

View reviewed changes

omkar-334 added 2 commits February 12, 2026 01:56

remove override test

370c784

Signed-off-by: Omkar Kabde <omkarkabde@gmail.com>

Merge branch 'fix-property' of github-personal:omkar-334/Curator into…

ba29581

… fix-property

greptile-apps Bot reviewed Feb 11, 2026

View reviewed changes

copy-pr-bot Bot temporarily deployed to test February 11, 2026 23:09 Inactive

copy-pr-bot Bot temporarily deployed to nemo-ci February 11, 2026 23:10 Inactive

sarahyurick approved these changes Feb 12, 2026

View reviewed changes

sarahyurick merged commit 2762f6e into NVIDIA-NeMo:main Feb 12, 2026
50 checks passed

Navigation Menu

Uh oh!

Add check to make sure all reserved keywords are attributes and not properties - #1490

Add check to make sure all reserved keywords are attributes and not properties#1490
sarahyurick merged 8 commits into
NVIDIA-NeMo:mainfrom
omkar-334:fix-property

omkar-334 commented Feb 11, 2026

Uh oh!

copy-pr-bot Bot commented Feb 11, 2026

Uh oh!

greptile-apps Bot commented Feb 11, 2026 •

edited

Loading

Uh oh!

greptile-apps Bot left a comment

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Uh oh!

omkar-334 commented Feb 11, 2026

Uh oh!

greptile-apps Bot left a comment

Uh oh!

sarahyurick Feb 11, 2026

Uh oh!

omkar-334 Feb 11, 2026

Uh oh!

greptile-apps Bot left a comment

Uh oh!

sarahyurick commented Feb 11, 2026

Uh oh!

sarahyurick left a comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Uh oh!

Conversation

omkar-334 commented Feb 11, 2026

Uh oh!

copy-pr-bot Bot commented Feb 11, 2026

Uh oh!

greptile-apps Bot commented Feb 11, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Greptile Overview

Greptile Summary

Confidence Score: 5/5

Important Files Changed

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

omkar-334 commented Feb 11, 2026

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sarahyurick Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

omkar-334 Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

greptile-apps Bot left a comment

Choose a reason for hiding this comment

Uh oh!

sarahyurick commented Feb 11, 2026

Uh oh!

sarahyurick left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

greptile-apps Bot commented Feb 11, 2026 •

edited

Loading