Skip to content

ci: Update vllm to 0.14.1 and override conflict - #1467

Merged
thomasdhc merged 3 commits into
mainfrom
donghyukc/vllm_0.14.1
Feb 5, 2026
Merged

ci: Update vllm to 0.14.1 and override conflict#1467
thomasdhc merged 3 commits into
mainfrom
donghyukc/vllm_0.14.1

Conversation

@thomasdhc

Copy link
Copy Markdown
Contributor

Description

Usage

# Add snippet demonstrating usage

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>
@thomasdhc thomasdhc added the r1.1.0 Pick this label for auto cherry-picking into r1.1.0 label Feb 5, 2026

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, 2 comments

Edit Code Review Agent Settings | Greptile

@greptile-apps

greptile-apps Bot commented Feb 5, 2026

Copy link
Copy Markdown
Contributor
Additional Comments (2)

pyproject.toml
Global NumPy override risk

override-dependencies pins numpy>=2.0.0,<=2.2.0 unconditionally, which forces NumPy 2.x for all installs (not just the vLLM extra). That’s a much broader behavioral change than the PR title suggests and can break environments/dependencies that still require NumPy <2. If the intent is only to unblock a specific extra (e.g., vLLM/Numba), consider scoping the override via markers/extras or documenting that Curator now requires NumPy 2.x across the board.


uv.lock
Lockfile now enforces NumPy 2.x

The new override { name = "numpy", specifier = ">=2.0.0,<=2.2.0" } means the resolved environment will prefer NumPy 2.x (and in this lock it becomes numpy==2.2.0). If any supported runtime/extra still relies on NumPy 1.x ABI/API (common for compiled deps), installs using this lock will fail at import/build time. Before merging, it would be good to confirm the project’s supported dependency set is NumPy-2-compatible or to narrow the override to only the extras that need it.

@praateekmahajan

Copy link
Copy Markdown
Contributor

@suiyoubi to verify before we merge

Signed-off-by: Dong Hyuk Chang <donghyukc@nvidia.com>

@greptile-apps greptile-apps Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 files reviewed, no comments

Edit Code Review Agent Settings | Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

r1.1.0 Pick this label for auto cherry-picking into r1.1.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants