Fix nemo_curator import in CPU only environment when GPU packages are installed. - #123
Merged
Merged
Conversation
…ult from dependencies being present but not importable in non gpu settings Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
Closed
jnke2016
pushed a commit
to jnke2016/Curator
that referenced
this pull request
Nov 12, 2025
…ult from dependencies being present but not importable in non gpu settings (NVIDIA-NeMo#123) Signed-off-by: Ayush Dattagupta <ayushdg95@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #109
Description
#27 Added support for installing a CPU only build of nemo_curator that works in cpu environments. However it didn't account for the case where the GPU version of curator was installed but the package was being used in CPU only environments.
One case this happens is when using the NeMo-FW container in CPU only environments. This pr extends the safe_import mechanism to fail on
importErrorinstead ofModuleNotFoundErrorfor cases where the module was present but import failed due to missing GPUs.One downside to this approach is that there's an implicit assumption that the importError on GPU packages stem from a missing GPU environment or missing packages, so we may wrongly classify other issues on import of these packages into the same bucket.
Usage
Checklist