Repository navigation
Add Nemotron VLM support in video captioning #1160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 11 commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
ce0a6af
Add NemotronH VLM support for video captioning
ronjer30 8bf8f34
Refactor caption generation and preparation to remove qwen_llm_input …
ronjer30 5efda69
Updated to use vLLM V1 engine for NemotronH Nano V2 model
ronjer30 eea9248
Reverted flash-attn back to 2.8.3 to work with latest upstream Nemotr…
ronjer30 78eb6b5
Enhance NemotronH VLM support for video captioning using HF model ins…
ronjer30 bea3f95
Fix unit tests and address review comments
ronjer30 7ecab77
Fix linting errors: remove trailing whitespace and add newline at EOF
ronjer30 ccca9d7
Improve dtype check in prompt_formatter to handle all floating types
ronjer30 76c365b
patch
weijiac0619 1c37443
clean
weijiac0619 a5d84b7
Merge pull request #1 from ronjer30/fix/cosmos-embed1-transformers-co…
ronjer30 f60dab8
nemotron preprocessing
weijiac0619 b8306cd
resolved conflicts
weijiac0619 d1064a4
stage2 fallback for qwen
weijiac0619 05bdd95
Merge branch 'main' into feature/nemotron-vlm
weijiac0619 9ec33e8
clean up
weijiac0619 d308896
resolved conflicts
weijiac0619 e13ece3
clean
weijiac0619 d8ea9ee
Merge branch 'main' into feature/nemotron-vlm
weijiac0619 c44c94d
comments
weijiac0619 c9a2c1c
cap transformers <5.0
weijiac0619 85bcb78
Merge branch 'main' into feature/nemotron-vlm
weijiac0619 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we need all the changes to the cosmos_embed1.py files ?
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, they're all needed for
trust_remote_code=Trueto work with newer transformers versions. If the file bulk is a concern, they can be moved to a separate _cosmos_embed1_compat.py.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
discussed with @suiyoubi offline. the patches are not needed with latest cosmos model. will clean this up