fix(mistral3): preserve medium VLM checkpoint layout - #2758
Merged
Conversation
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
Additional nemo-ci trigger for the original SFT MedPix job requested from https://gitlab-master.nvidia.com/dl/JoC/nemo-ci/-/jobs/346789236.
Current state: root pipeline is running; |
Contributor
Author
|
Superseding the earlier retrigger for
The leaf job is currently running. |
Contributor
Author
|
/ok to test ffeff89 |
akoumpa
enabled auto-merge (squash)
June 24, 2026 20:47
Contributor
Author
|
Final follow-up for the extra |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
language_model.model.*mapping for the smaller Ministral/Devstral-style layoutsconfig.text_config.model_typeplusconfig.text_config.num_hidden_layers, not from the repo idFailure
The regression showed up while loading the base model for
mistral3p5_128b_medpix_lora:Mistral-Medium-3.5-128Bstores full-VLM body keys in the HF/runtime layout (model.language_model.*,model.vision_tower.*,model.multi_modal_projector.*), so remapping those destination keys tolanguage_model.model.*made DCP request keys that are absent from that checkpoint.Validation
pytest -q tests/unit_tests/models/mistral3_vlm/test_state_dict_adapter.py tests/unit_tests/models/mistral3_vlm/test_model.py-> 53 passedmistral3p5_128b_medpix_lora: https://gitlab-master.nvidia.com/dl/JoC/nemo-ci/-/jobs/347146651ministral3_3b_squad: https://gitlab-master.nvidia.com/dl/JoC/nemo-ci/-/jobs/347146977