cp: fix(diffusion): resolve flux nightly CI failures (2529) into r0.5.0 - #2567
Merged
Conversation
Two startup failures in the diffusion nightly functional tests: - flux_t2i_flow_lora: the CI launcher unconditionally passed --fsdp.dp_size, which injects an 'fsdp' section and conflicts with the recipe's 'ddp' section (mutual-exclusion ValueError). The launcher now skips the override for DDP-based recipes. - flux_t2i_flow: _build_diffusion_parallel_manager_args called dict() on ConfigNode sections, which are not iterable. Normalize fsdp/ddp sections via to_dict() before use; this also fixes the identical latent bug in the DDP branch. Signed-off-by: Pranav Prashant Thombre <pthombre@nvidia.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: NeMo Bot <nemo-bot@nvidia.com>
Contributor
Author
|
/ok to test 803a423 |
akoumpa
approved these changes
Jun 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
beep boop [馃]: Hi @pthombre 馃憢,