refactor: Remove separate moe_mesh references - #2123
Closed
edjson wants to merge 25 commits into
Closed
Conversation
Signed-off-by: Edison <edisonggacc@gmail.com>
edjson
requested review from
HuiyingLi,
ZhiyuLi-Nvidia,
adil-a,
akoumpa,
athitten,
hemildesai,
pthombre and
zyzhou5
as code owners
May 4, 2026 16:20
3 tasks
Contributor
|
/ok to test f2e9211 |
Contributor
|
/ok to test 06f1dab |
Signed-off-by: Edison <edisonggacc@gmail.com>
Contributor
|
/ok to test cfeaacf |
Contributor
|
/ok to test dadce47 |
Contributor
|
/ok to test b4a2d03 |
Signed-off-by: Edison <edisonggacc@gmail.com>
Contributor
|
/ok to test 0998758 |
Contributor
|
/ok to test eaef478 |
Signed-off-by: Edison <edisonggacc@gmail.com>
Signed-off-by: edjson <edisonggacc@gmail.com>
Contributor
Author
|
@akoumpa could you test this when you get the chance please? |
Contributor
|
/ok to test 596b60b |
Contributor
Author
|
Closing in favor of #2266 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
Removes
moe_meshfrom the user-facing APIChangelog
auto_model.py: removedmoe_meshfrom signature, docstrings,_retryforwarding, andMeshContext.from_meshescallsextract_nemo_activations.py: removed stalemoe_mesh=test_auto_model.py: addedTestMoeMeshRemovedFromAPIto guard against regressionsBefore your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information