docs(llm): drop validate-yaml reference from DeepSeek V4 Flash guide - #2054
Merged
HuiyingLi merged 3 commits intoApr 26, 2026
Merged
Conversation
Removes the validate-yaml bullet under "Launch Training" and the "Quick infrastructure validation" subsection. The validate harness is an internal smoke-test config, not a user-facing finetune recipe; the guide should advertise only the HellaSwag recipe. Follow-up to NVIDIA-NeMo#2053 (the original change was force-pushed after the PR had already merged, so the deletion did not land on main). Signed-off-by: khazic <khazzz1c@gmail.com>
khazic
requested review from
HuiyingLi,
adil-a,
akoumpa,
athitten,
hemildesai,
jgerh,
pthombre and
zyzhou5
as code owners
April 25, 2026 09:59
Mirrors the per-model rollout pattern used for MiniMax-M2.7 (NVIDIA-NeMo#1785): news entry at the top of the README, a dedicated model-coverage page under deepseek-ai/, and registration of the new page in the LLM index (architecture table + toctree). - README.md (news entry) - docs/model-coverage/llm/deepseek-ai/dsv4-flash.md (new) - docs/model-coverage/llm/index.md (table + toctree) Signed-off-by: Huiying Li <willwin.lee@gmail.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
HuiyingLi
force-pushed
the
docs/dsv4-flash-drop-validate
branch
from
April 25, 2026 10:11
6a1eab2 to
39db410
Compare
Contributor
|
/ok to test 39db410 |
HuiyingLi
enabled auto-merge (squash)
April 25, 2026 10:12
HuiyingLi
previously approved these changes
Apr 25, 2026
The {download} directive on the recipe yaml fails the Sphinx build
with `download.not_readable` because
examples/llm_finetune/deepseek_v4/deepseek_v4_flash_hellaswag.yaml
is added by the model PR (NVIDIA-NeMo#2039), which has not yet landed on main.
Use a plain GitHub link until NVIDIA-NeMo#2039 merges; a follow-up can switch
back to {download} once the file is on main.
Signed-off-by: khazic <khazzz1c@gmail.com>
auto-merge was automatically disabled
April 25, 2026 15:49
Head branch was pushed to by a user without write access
HuiyingLi
added a commit
to khazic/Automodel_lao
that referenced
this pull request
Apr 27, 2026
Merged ``origin/main`` into ``feat/deepseek-v4-flash``. Main already added ``docs/model-coverage/llm/deepseek-ai/dsv4-flash.md`` (PRs NVIDIA-NeMo#2053 and NVIDIA-NeMo#2054) which covers ``DeepseekV4ForCausalLM`` for the doc-coverage check; my earlier ``deepseek-v4.md`` was a duplicate. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> Signed-off-by: HuiyingLi <willwin.lee@gmail.com>
Closed
Closed
kashif
pushed a commit
to kashif/Automodel
that referenced
this pull request
May 25, 2026
…VIDIA-NeMo#2054) * docs(llm): drop validate-yaml reference from DeepSeek V4 Flash guide Removes the validate-yaml bullet under "Launch Training" and the "Quick infrastructure validation" subsection. The validate harness is an internal smoke-test config, not a user-facing finetune recipe; the guide should advertise only the HellaSwag recipe. Follow-up to NVIDIA-NeMo#2053 (the original change was force-pushed after the PR had already merged, so the deletion did not land on main). Signed-off-by: khazic <khazzz1c@gmail.com> * docs(llm): add DeepSeek V4 Flash to README + model-coverage index Mirrors the per-model rollout pattern used for MiniMax-M2.7 (NVIDIA-NeMo#1785): news entry at the top of the README, a dedicated model-coverage page under deepseek-ai/, and registration of the new page in the LLM index (architecture table + toctree). - README.md (news entry) - docs/model-coverage/llm/deepseek-ai/dsv4-flash.md (new) - docs/model-coverage/llm/index.md (table + toctree) Signed-off-by: Huiying Li <willwin.lee@gmail.com> Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com> * docs(llm): use plain link for hellaswag yaml until model PR lands The {download} directive on the recipe yaml fails the Sphinx build with `download.not_readable` because examples/llm_finetune/deepseek_v4/deepseek_v4_flash_hellaswag.yaml is added by the model PR (NVIDIA-NeMo#2039), which has not yet landed on main. Use a plain GitHub link until NVIDIA-NeMo#2039 merges; a follow-up can switch back to {download} once the file is on main. Signed-off-by: khazic <khazzz1c@gmail.com> --------- Signed-off-by: khazic <khazzz1c@gmail.com> Co-authored-by: Huiying Li <willwin.lee@gmail.com> Co-authored-by: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #2053. Removes the
deepseek_v4_flash_validate.yamlreferences from the DeepSeek V4 Flash fine-tuning guide. The validate harness is an internal smoke-test config — not a user-facing fine-tune recipe — so the user-facing guide should advertise only the HellaSwag recipe.What changes
In
docs/guides/llm/dsv4-flash.md:Two recipes ship under …→A ready-to-use recipe ships at …).Test plan