Skip to content

feat: replace MeaningUnitAspect enum with open-ended str #206

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
asteier2026 merged 4 commits into from
Aug 14, 2026
Merged

feat: replace MeaningUnitAspect enum with open-ended str #206

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ae6b5da
feat: replace MeaningUnitAspect enum with open-ended str
asteier2026 Jul 2, 2026
373f2b6
fix: add min_length=1 to MeaningUnitSchema.aspect and QualityQAItemSc…
asteier2026 Jul 2, 2026
bb154d8
test: add regression test for free-form aspect strings outside former…
asteier2026 Aug 14, 2026
5533f68
style: apply ruff format to test_qa_generation.py
asteier2026 Aug 14, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions src/anonymizer/engine/schemas/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
EntityCategory,
EntityDispositionSchema,
EntitySource,
MeaningUnitAspect,
MeaningUnitImportance,
MeaningUnitSchema,
MeaningUnitsSchema,
Expand Down Expand Up @@ -90,7 +89,6 @@
"EntityCategory",
"EntityDispositionSchema",
"EntitySource",
"MeaningUnitAspect",
"MeaningUnitImportance",
"MeaningUnitSchema",
"MeaningUnitsSchema",
Expand Down
25 changes: 3 additions & 22 deletions src/anonymizer/engine/schemas/rewrite.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,7 +33,7 @@
Uses LLMJudgeColumnConfig with Score rubrics (no custom schema needed)

Supporting enums: Domain, EntitySource, EntityCategory, SensitivityLevel,
ProtectionMethod, CombinedRiskLevel, MeaningUnitAspect, PrivacyAnswer
ProtectionMethod, CombinedRiskLevel, PrivacyAnswer
"""

from __future__ import annotations
Expand Down Expand Up @@ -249,33 +249,14 @@ class StrictSensitivityDispositionSchema(SensitivityDispositionSchema):
# ---------------------------------------------------------------------------


class MeaningUnitAspect(str, Enum):
ROLE = "role"
PROCESS = "process"
RELATIONSHIP = "relationship"
ENVIRONMENT = "environment"
ROUTINE = "routine"
CREATIVE_OUTPUT = "creative_output"
VALUE = "value"
MOTIVATION = "motivation"
INFLUENCE = "influence"
AUDIENCE = "audience"
LEGAL_BASIS = "legal_basis"
INSTITUTION = "institution"
JUSTIFICATION = "justification"
PROCEDURAL_STATUS = "procedural_status"
TEMPORAL_SEQUENCE = "temporal_sequence"
RIGHTS_IMPACT = "rights_impact"


class MeaningUnitImportance(str, Enum):
critical = "critical"
important = "important"


class MeaningUnitSchema(BaseModel):
id: int = Field(ge=1)
aspect: MeaningUnitAspect
aspect: str = Field(min_length=1)
unit: str = Field(min_length=1)
importance: MeaningUnitImportance

Expand All @@ -294,7 +275,7 @@ class MeaningUnitsSchema(BaseModel):

class QualityQAItemSchema(BaseModel):
id: int
aspect: str
aspect: str = Field(min_length=1)
importance: MeaningUnitImportance
question: str
reference_answer: str
Expand Down
5 changes: 2 additions & 3 deletions tests/engine/test_qa_generation.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,6 @@
EntityCategory,
EntityDispositionSchema,
EntitySource,
MeaningUnitAspect,
MeaningUnitImportance,
MeaningUnitSchema,
MeaningUnitsSchema,
Expand Down Expand Up @@ -75,13 +74,13 @@
units=[
MeaningUnitSchema(
id=1,
aspect=MeaningUnitAspect.ROLE,
aspect="role",
Comment thread
asteier2026 marked this conversation as resolved.
unit="An individual works as a software engineer.",
importance=MeaningUnitImportance.critical,
),
MeaningUnitSchema(
id=2,
aspect=MeaningUnitAspect.ENVIRONMENT,
aspect="environment",
unit="The individual works remotely.",
importance=MeaningUnitImportance.important,
),
Expand Down