-
Notifications
You must be signed in to change notification settings - Fork 148
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
adding unit test for end-to-end example (#669)
* adding unit test for multi-gpu example * added test for notebook 03 * fixed formatting * update * update * Update 01-ETL-with-NVTabular.ipynb day of week is between 0 and 6; it must be scaled with a max value of 6 to produce correct values from the 0-1 range. If we do col+1 and scale with 7, then a section of the 0-2pi range (for Sine purposes) will not be represented. * Update 01-ETL-with-NVTabular.ipynb Reversed the previous edit for weekday scaling. It is correct that it should be scaled between 0-7, because day 0 (unused/nonapplicable after +1 added) overlaps with day 7 for Sine purposes. Monday should scale to 1/7, Sunday should scale to 7/7 to achieve even distribution of days along the sinus curve. * reduce num_rows * Update test_end_to_end_session_based.py * Update 01-ETL-with-NVTabular.ipynb * updated test script and notebook * updated file * removed nb3 test due to multi-gpu freezing issue * revised notebooks, added back nb3 test * fixed test file with black * update test py * update test py * Use `python -m torch.distributed.run` instead of `torchrun` The `torchrun` script installed in the system is a python script with a shebang line starting with `#!/usr/bin/python3` This picks up the wrong version of python when running in a virtualenv like our tox test environment. If instead this were `#!/usr/bin/env python3` it would work ok in a tox environment to call `torchrun`. However, until either the pytorch package is updated for this to happen or we update our CI image for this to take place. Running the python command directly is more reliable. --------- Co-authored-by: rnyak <[email protected]> Co-authored-by: edknv <[email protected]> Co-authored-by: rnyak <[email protected]> Co-authored-by: Oliver Holworthy <[email protected]>
- Loading branch information
1 parent
f3c4d2a
commit 348c963
Showing
4 changed files
with
631 additions
and
329 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.