docs: refresh AI-Q 2.2 architecture - #395
Conversation
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
|
Auto-sync is disabled for draft pull requests in this repository. Workflows must be run manually. Contributors can view more details about this message here. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: ASSERTIVE Plan: Enterprise Run ID: 📒 Files selected for processing (2)
📜 Recent review details⏰ Context from checks skipped due to timeout. (3)
🧰 Additional context used📓 Path-based instructions (2)**/*📄 CodeRabbit inference engine (AGENTS.md)
Files:
{docs/**,README.md,CONTRIBUTING.md,SECURITY.md,CODE-OF-CONDUCT.md}⚙️ CodeRabbit configuration file
Files:
🔇 Additional comments (2)
WalkthroughDocumentation and generated metadata now describe per-job Modal/OpenShell sandboxing, policy attestation, execution boundaries, expanded data-source setup, roadmap updates, and Azure AI Search support. ChangesDocumentation alignment
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@README.md`:
- Around line 140-143: Update the README’s provider configuration table and
setup instructions to fully document every newly advertised source: Exa,
SerpAPI, and SearchAPI, including their correct environment-variable names,
installation or setup commands, and usage examples where applicable. Review the
added Exa installation guidance and existing commands for accuracy and remove or
narrow provider claims that cannot be supported by complete instructions.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: ASSERTIVE
Plan: Enterprise
Run ID: f6eca19d-e20c-4da6-b956-9cb67bcf9f7d
⛔ Files ignored due to path filters (2)
docs/assets/AIQ-arch-light.pngis excluded by!**/*.pngdocs/source/_static/AIQ-arch-light.pngis excluded by!**/*.png
📒 Files selected for processing (9)
.secrets.baselineCHANGELOG.mdREADME.mddocs/source/architecture/agents/deep-researcher.mddocs/source/architecture/overview.mddocs/source/customization/configuration-reference.mddocs/source/examples/skills-sandbox/index.mddocs/source/get-started/installation.mddocs/source/resources/faq.md
📜 Review details
⏰ Context from checks skipped due to timeout. (3)
- GitHub Check: Lint and Hooks
- GitHub Check: Script Validation
- GitHub Check: Pytest and Coverage
🧰 Additional context used
📓 Path-based instructions (3)
**/*
📄 CodeRabbit inference engine (AGENTS.md)
**/*: Keep changes inside this repository, avoid editing adjacent repositories, and scope changes to the smallest relevant independent package, especially undersources/.
Run the narrowest relevant validation command first and broaden to the full suite only when a change crosses shared boundaries.
Keep pull requests scoped, exclude unrelated files and generated artifacts, never include secrets, and provide validation commands and results.
**/*: Do not include secrets, credentials, private hostnames, internal-only logs, customer data, or generated local artifacts.
Add or update tests for behavior changes.
Files:
CHANGELOG.mddocs/source/customization/configuration-reference.mddocs/source/resources/faq.mddocs/source/architecture/agents/deep-researcher.mddocs/source/get-started/installation.mddocs/source/architecture/overview.mddocs/source/examples/skills-sandbox/index.mdREADME.md
docs/source/**/*
📄 CodeRabbit inference engine (AGENTS.md)
Update canonical documentation under
docs/source/when behavior, configuration, or workflows change; do not duplicate full documentation pages into skills.
Files:
docs/source/customization/configuration-reference.mddocs/source/resources/faq.mddocs/source/architecture/agents/deep-researcher.mddocs/source/get-started/installation.mddocs/source/architecture/overview.mddocs/source/examples/skills-sandbox/index.md
{docs/**,README.md,CONTRIBUTING.md,SECURITY.md,CODE-OF-CONDUCT.md}
⚙️ CodeRabbit configuration file
{docs/**,README.md,CONTRIBUTING.md,SECURITY.md,CODE-OF-CONDUCT.md}: Review documentation for command accuracy, branch-name consistency, current CI and copy-pr-bot behavior, public
vs internal boundary clarity, stale examples, and links that no longer match the repository layout.
Files:
docs/source/customization/configuration-reference.mddocs/source/resources/faq.mddocs/source/architecture/agents/deep-researcher.mddocs/source/get-started/installation.mddocs/source/architecture/overview.mddocs/source/examples/skills-sandbox/index.mdREADME.md
🔇 Additional comments (9)
CHANGELOG.md (1)
26-26: LGTM!README.md (1)
69-69: LGTM!Also applies to: 289-289, 465-472, 483-483
docs/source/customization/configuration-reference.md (1)
655-655: LGTM!docs/source/examples/skills-sandbox/index.md (1)
9-15: LGTM!Also applies to: 32-40, 116-121, 228-229
docs/source/architecture/overview.md (1)
25-42: LGTM!Also applies to: 52-55
docs/source/architecture/agents/deep-researcher.md (1)
127-145: LGTM!.secrets.baseline (1)
136-136: LGTM!Also applies to: 358-358
docs/source/get-started/installation.md (1)
54-54: LGTM!Also applies to: 100-100
docs/source/resources/faq.md (1)
70-70: LGTM!
Signed-off-by: Ajay Thorve <athorve@nvidia.com>
|
LGTM |
|
/merge |
Overview
Refresh the release/2.2 architecture documentation so the diagram and surrounding guidance match the current implementation:
This is documentation-only and does not change runtime behavior.
DCO sign-off for the squash commit
Signed-off-by: Ajay Thorve athorve@nvidia.com
Signed-off-by: Ajay Thorve 20476096+AjayThorve@users.noreply.github.com
Validation
make -C docs SPHINXBUILD=../.venv/bin/sphinx-build SPHINXOPTS='-W --keep-going -n' htmlhttps://you.com/docs/quickstart, which returned HTTP 403 to the checker.uv lock --checkgit diff --checklibsimdjson.29.dylib; Sphinx link checking was run directly as described above.git commit -sor an equivalent sign-off.Where should reviewers start?
Start with
docs/source/architecture/overview.mdanddocs/source/_static/AIQ-arch-light.png, then reviewdocs/source/architecture/agents/deep-researcher.mdfor the implementation-boundary explanation.Related Issues
Summary by CodeRabbit
.secrets.baseline) to reflect updated README detection details.