Forward-merge release/2.2 into develop - #376
Merged
Merged
Conversation
#### Overview Addresses FDR feedback for the AI-Q release docs and public skills: - Adds missing Helm documentation for Modal sandbox and S3-compatible artifact storage environment variables [minor] - Corrects the local NIMs GPU-memory note so it matches the `nvidia/nemotron-3-super-120b-a12b` model used in the example. - Updates public skill headings to the expected `When to Use This Skill` and `Workflow` format. - Adds simple sibling-distractor negative eval cases for `aiq-deploy` and `aiq-research`. #### DCO sign-off for the squash commit Signed-off-by: Soumili Nandi soumilin@nvidia.com #### Validation - [x] I ran the relevant local checks or explained why they are not applicable. - [x] I added or updated tests for behavior changes. - [x] I updated documentation for user-facing or contributor-facing changes. - [x] I confirmed this PR does not include secrets, credentials, or internal-only data. - [x] I certify this contribution under the Developer Certificate of Origin (DCO) and signed my commits with `git commit -s` or an equivalent sign-off. - [x] I replaced the DCO sign-off placeholder with my GitHub commit identity and kept the required angle brackets around the email address. Validation run: doc changes - skill validated using invoking via Agent #### Where should reviewers start? Start with: - `skills/aiq-deploy/SKILL.md` - `skills/aiq-research/SKILL.md` - `skills/aiq-deploy/evals/evals.json` - `skills/aiq-research/evals/evals.json` The docs-only deployment updates are in: - `deploy/helm/README.md` - `docs/source/examples/cli-with-local-nims.md` #### Related Issues - Relates to # ## Summary by CodeRabbit * **Documentation** * Extended deployment guidance with additional optional artifact storage provider and credential configuration details. * Updated local NIM GPU sizing guidance to avoid fixed VRAM targets and instead reference current model requirements and hardware inspection. * Refreshed headings in deployment and research workflow guides for clearer structure. * **Tests** * Added new eval scenarios to verify correct handling of negative research/deployment requests and routing/initialization behavior. * **Maintenance** * Adjusted a Python dependency version constraint for improved compatibility. Authors: - Soumili Nandi (https://github.com/soumilinandi) Approvers: - Ajay Thorve (https://github.com/AjayThorve) URL: #374
Author
|
SUCCESS - forward-merge complete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Forward-merge triggered by push to release/2.2 that creates a PR to keep develop up-to-date. If this PR is unable to be immediately merged due to conflicts, it will remain open for the team to manually merge. See forward-merger docs for more info.