feat(skills): complete maintainer skill set and extend aiq-research - #277
Merged
AjayThorve merged 4 commits intoJun 16, 2026
Merged
Conversation
Adds the aiq-add-tool Agent Skill (SKILL.md + nat-function-pattern and testing references) covering the NAT function package pattern, config schema, @register_function flow, agent tools wiring, and tests. Builds on the devskills-foundation scaffolding. Signed-off-by: Eli Fajardo <efajardo@nvidia.com>
Add a maintainer skill that helps a coding agent choose and run the right validation checks (Python, frontend, docs, evals) for the surfaces a change touches, grounded in AGENTS.md and CONTRIBUTING.md. Implements DEVSKILLS-5 (AIQ-3438). Signed-off-by: Eli Fajardo <efajardo@nvidia.com>
Add a maintainer skill covering branch scoping, DCO sign-off, filling the PR template with real validation evidence, and the copy-pr-bot CI/merge flow. Reuses aiq-release-qa for validation rather than duplicating commands. Implements DEVSKILLS-6 (AIQ-3439). Signed-off-by: Eli Fajardo <efajardo@nvidia.com>
Document follow-up usage for the aiq-research consumer skill: answering questions about a returned report (ask) and re-running with a refined query (redo), reusing the existing auth, polling, and report-retrieval flow. Implements DEVSKILLS-7 (AIQ-3440). Signed-off-by: Eli Fajardo <efajardo@nvidia.com>
WalkthroughAdds three new agent skill directories under ChangesNew Agent Skills and Symlink Wiring
aiq-research Follow-up Update
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Member
|
/ok to test 3f43277 |
AjayThorve
approved these changes
Jun 16, 2026
AjayThorve
left a comment
Member
There was a problem hiding this comment.
Looks really good, thanks Eli!
AjayThorve
merged commit Jun 16, 2026
da1071b
into
NVIDIA-AI-Blueprints:develop
9 of 10 checks passed
Merged
5 tasks
zhongxuanwang-nv
added a commit
to zhongxuanwang-nv/aiq
that referenced
this pull request
Jun 23, 2026
…ainer skill artifacts The maintainer skill set (.agents/skills/) shipped in NVIDIA-AI-Blueprints#269/NVIDIA-AI-Blueprints#277 carried a few documentation defects found while auditing it against the live AI-Q config schema and the sibling NeMo-Relay skill set. Documentation-only; no skills are added or removed. - aiq-add-data-source: correct the data_source_registry YAML example to match DataSourceEntry / DataSourceRegistryConfig and the working configs -- use the `data_sources` instance name, drop the non-existent `category` field, and list `tools` as plain function-instance-name strings (not `_type:` mappings). Add the missing `ruff format --check` to the validation block. - aiq-add-data-source: replace the dangling `aiq-ui-change` reference (no such skill) with a generic frontends/ui note. - aiq-prepare-pr, aiq-release-qa: remove stray `</content>` artifacts left at the end of three skill files. - aiq-release-qa: the npm "only these scripts exist" claim was inaccurate (package.json defines many more); reword to recommend the canonical checks without asserting exhaustiveness. - docs/integration/agent-skills.md, .agents/skills/README.md: list all four maintainer skills and all four .claude/skills maintainer symlinks. Validation: scripts/validate_skills.py (6 skills OK), pytest tests/test_agent_skills.py (4 passed), and pre-commit (detect-secrets, validate-skills, markdown-link-check) on the changed files all pass. Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
cdgamarose-nv
pushed a commit
that referenced
this pull request
Jun 23, 2026
…ainer skill artifacts (#281) The maintainer skill set (.agents/skills/) shipped in #269/#277 carried a few documentation defects found while auditing it against the live AI-Q config schema and the sibling NeMo-Relay skill set. Documentation-only; no skills are added or removed. - aiq-add-data-source: correct the data_source_registry YAML example to match DataSourceEntry / DataSourceRegistryConfig and the working configs -- use the `data_sources` instance name, drop the non-existent `category` field, and list `tools` as plain function-instance-name strings (not `_type:` mappings). Add the missing `ruff format --check` to the validation block. - aiq-add-data-source: replace the dangling `aiq-ui-change` reference (no such skill) with a generic frontends/ui note. - aiq-prepare-pr, aiq-release-qa: remove stray `</content>` artifacts left at the end of three skill files. - aiq-release-qa: the npm "only these scripts exist" claim was inaccurate (package.json defines many more); reword to recommend the canonical checks without asserting exhaustiveness. - docs/integration/agent-skills.md, .agents/skills/README.md: list all four maintainer skills and all four .claude/skills maintainer symlinks. Validation: scripts/validate_skills.py (6 skills OK), pytest tests/test_agent_skills.py (4 passed), and pre-commit (detect-secrets, validate-skills, markdown-link-check) on the changed files all pass. Signed-off-by: Zhongxuan Wang <daniewang@nvidia.com>
This was referenced Jul 7, 2026
This was referenced Jul 14, 2026
This was referenced Jul 21, 2026
6 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Adds the remaining AI-Q maintainer Agent Skills and extends the
aiq-researchconsumer skill, completing the maintainer skill set started in #269.
aiq-add-tool: maintainer skill for adding a general-purpose NAT-functiontool under
sources/—FunctionBaseConfigschema,@register_function,wiring into an agent's
toolslist, and tests.aiq-release-qa: maintainer skill for choosing and running the rightvalidation (Python, frontend, docs, evals) for the surfaces a change touches,
grounded in
AGENTS.mdandCONTRIBUTING.md.aiq-prepare-pr: maintainer skill for branch scoping, DCO sign-off,filling the PR template with real evidence, and the copy-pr-bot CI/merge flow.
Reuses
aiq-release-qafor validation rather than duplicating.aiq-research: adds report ask/redo follow-up usage to the consumerskill, reusing the existing auth, polling, and report-retrieval flow (no new
helper-script commands).
Each maintainer skill is a real directory under
.agents/skills/with a.claude/skills/compatibility symlink. No deployed-product behavior changes —these are guidance for coding agents working in the repo.
Validation
docs/source/unchanged)git commit -sor an equivalent sign-off.Related Issues
Summary by CodeRabbit
Release Notes
Documentation