Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update graphviz dependency #268

Merged
merged 2 commits into from
Nov 16, 2022
Merged

Update graphviz dependency #268

merged 2 commits into from
Nov 16, 2022

Conversation

LachlanCourt
Copy link
Contributor

No description provided.

ysims
ysims previously approved these changes Nov 14, 2022
Copy link
Member

@ysims ysims left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LachlanCourt
Copy link
Contributor Author

This appears to have fixed the problem although the build has a number of errors about event emitter @JosephusPaye MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 end listeners added to [PassThrough]. Use emitter.setMaxListeners() to increase limit

I don't think it has stopped the build but not sure if it's a major problem

@LachlanCourt LachlanCourt linked an issue Nov 14, 2022 that may be closed by this pull request
@JosephusPaye
Copy link
Member

That error you're seeing occurs when you have an event emitter which has more than 10 distinct listeners for the same event. Although the warning is not 100% accurate, when it shows up it usually means something weird is happening in the code (like registering event listeners in a loop).

We can get more information about where the issue is happening by running this...

node --trace-warnings node_modules/.bin/gatsby build

... which produces this output:

(node:69390) MaxListenersExceededWarning: Possible EventEmitter memory leak detected. 11 end listeners added to [PassThrough]. Use
emitter.setMaxListeners() to increase limit
    at _addListener (node:events:587:17)
    at PassThrough.addListener (node:events:605:10)
    at PassThrough.Readable.on (node:internal/streams/readable:887:35)
    at eos (node:internal/streams/end-of-stream:177:10)
    at pipe (node:internal/streams/pipeline:392:10)
    at pipelineImpl (node:internal/streams/pipeline:323:25)
    at pipeline (node:internal/streams/pipeline:151:10)
    at probeStream (/home/josephus/Code/nubook/node_modules/probe-image-size/stream.js:63:8)
    at get_image_size (/home/josephus/Code/nubook/node_modules/probe-image-size/index.js:13:12)
    at getImageSizeAsync (/home/josephus/Code/nubook/node_modules/gatsby-plugin-sharp/index.js:67:28)
    at getImageMetadata (/home/josephus/Code/nubook/node_modules/gatsby-plugin-sharp/image-data.js:33:39)
    at generateImageData (/home/josephus/Code/nubook/node_modules/gatsby-plugin-sharp/image-data.js:121:26)
    at resolver (/home/josephus/Code/nubook/node_modules/gatsby-transformer-sharp/customize-schema.js:605:31)
    at resolver (/home/josephus/Code/nubook/node_modules/gatsby/src/schema/resolvers.ts:668:20)
    at wrappedTracingResolver (/home/josephus/Code/nubook/node_modules/gatsby/src/schema/resolvers.ts:668:20)

Showing that the issue is in Gatsby itself (none of the stack entries are our code). Perhaps there's an updated version of Gatsby where this is fixed. A quick search shows Gatsby's had similar issues before:

@LachlanCourt
Copy link
Contributor Author

Ah thanks, I wasn't sure what path I was supposed to put after the node --trace_warnings ! This should hopefully fix the problem :)

@LachlanCourt LachlanCourt requested a review from ysims November 14, 2022 06:38
Copy link
Member

@JosephusPaye JosephusPaye left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@LachlanCourt LachlanCourt merged commit aebe4f2 into main Nov 16, 2022
@LachlanCourt LachlanCourt deleted the court/update_graphviz branch November 16, 2022 04:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cannot find Graphviz Wasm
3 participants