Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve failed calibration handling #125

Merged
merged 14 commits into from
Nov 14, 2024
Merged

Improve failed calibration handling #125

merged 14 commits into from
Nov 14, 2024

Conversation

aromanielloNTIA
Copy link
Member

@aromanielloNTIA aromanielloNTIA commented Nov 7, 2024

Improve handling of situations where certain channels intermittently receive NaN calibration results.

  • Trigger a single retry of channel calibration if either gain or noise figure is computed as NaN or non-finite number in calibrate_y_factor action
  • Adjust "detail" string returned by cal action by truncating numbers, so more channels can display in the "detail" message
  • Limit numpy version to <2, since numpy>=2 caused crashes (seemingly within the numexpr module) when running in scos-sensor. Keeping the more stable and widely supported numpy for now until there is a need to upgrade and/or more comprehensive testing can be done to determine which other dependencies need to also be updated.

Base automatically changed from drop-python-3.8 to master November 7, 2024 22:33
@aromanielloNTIA aromanielloNTIA self-assigned this Nov 13, 2024
@aromanielloNTIA aromanielloNTIA marked this pull request as ready for review November 13, 2024 22:42
Copy link
Member

@jhazentia jhazentia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@jhazentia jhazentia merged commit 495b7fb into master Nov 14, 2024
4 checks passed
@jhazentia jhazentia deleted the cal_NAN_prevention branch November 14, 2024 19:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants