Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sea 178 test actions loading #118

Merged

Conversation

jhazentia
Copy link
Member

PR reintroduces changes from #110

  • Updated precommit versions and autoformatted
  • added ability to set calibration adjust for data product action (useful for testing with mock)
  • sensor cal only added to metadata and measurement result if calibration adjust is true
  • added plugin_name property to sigan_iface; this is used to put the plugin name in the status page and in the metadata
  • remove "calibration_datetime" in global section of metadata, replaced by calibration object in capture
  • fix calculation of duration in metadata in the m4s action - this appeared to not be converted to milliseconds as expected (always showed 0 in metadata)
  • changed the logic in the base action configure_preselector method to first check if preselector is configurable
  • test data product action updated to be consistent with cbrs measure baseline action
  • actions and test actions (except logger) only loaded if SIGAN_MODULE and SIGAN_CLASS are set to the mock sigan in scos-actions
  • added sigan to mock GPS constructor just like the scos-usrp USRPLocation class
  • Due to sigan and GPS objects being initialized in scos-sensor instead of scos-usrp, sensor object now passed to GPS methods in order for scos-usrp to access USRP API for GPS. Previously sigan was passed to GPS Interface implementation through constructor.
  • Updated to be compatible with the latest scos-actions:
    • Acquire IQ called though sensor object rather than sigan with sensor object now handling calibration adjustments
    • Sensor overload code moved from scos-usrp to sensor in scos-actions
    • remove clock_rate_lookup_by_sample_rate related code, instead scos-usrp will always maximize clock_rate based on sample rate
  • Check if temperature exists in cal data before adding to cal metadata

@jhazentia jhazentia requested a review from dboulware April 26, 2024 17:26
Copy link
Contributor

@dboulware dboulware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@dboulware dboulware merged commit bb3b03d into master Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants