Separate on board calibrations, support additional loss to antenna, add disk usage to diagnostics #114
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Avoids some redundant additions and subtractions by working internally in dBW instead of dBm
- fully remove calibration from sigan interfaces. all calibration handling happens at the sensor object level - alter the sigan interface: retry logic and calibration scaling now happens in the sensor acquire_samples method instead of sigan versions. - dynamically set data reference point as part the measurement result based on which calibration scaling was applied
automatically recompute calibration data in the getter method
- Remove outdated and unnecessary instance variables - Remove retry logic from acquire_samples to account for changes in the Sensor object - Remove redundant properties that are the same as the base class
These properties no longer need to be overriden. Subclass constructors can just set the correct instance variables instead.
- simplify recompute_calibration methods - cal_params is now an argument of acquire_time_domain_samples, and is intended to be used by passing action.parameters dicts which contain the required key/values to match calibration data to the measurement - add some specific calibration-related exceptions - update actions and unit tests
jhazentia
requested changes
Mar 20, 2024
…ation. Remove commented out code. Reuse create_capture_segment in stepped frequency IQ action. Use frequency from measurement_result in MeasurementAction. Fix description of the calibration data that will be used in the docstring in Sensor acquire_time_domain_samples.
jhazentia
reviewed
Mar 25, 2024
jhazentia
reviewed
Mar 25, 2024
jhazentia
reviewed
Mar 25, 2024
jhazentia
requested changes
Mar 25, 2024
jhazentia
approved these changes
Mar 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces significant changes to the handling of calibrations to separate the calibrations performed on board from the initial calibration and introduces a new differential calibration (that cannot be updated) to add additional loss values to move the reference point to the antenna. The y-factor action is updated to create a new sensor calibration if there isn't one, and only saves calibration updates to an onboard calibration file. Calibration annotations are updated in each action to appropriately adjust the gain, noise figure, and reference based on whether or not a differential calibration is used or not. In addition, the compression point is maintained from the initial calibration if present. Finally, this also updates the diagnostic metadata to include disk_usage.