Register signal analyzer signal/signal analyzer monitor #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aromanielloNTIA
approved these changes
Jan 9, 2024
| @@ -68,6 +75,8 @@ def load_preselector(preselector_config, module, preselector_class_name): | |||
| return ps | |||
|
|
|||
|
|
|||
| signal_analyzer_monitor = signal_analyzer_monitor | |||
There was a problem hiding this comment.
This line seems to be unnecessary
| from .status_monitor import StatusMonitor | ||
|
|
||
| status_registrar = StatusMonitor() | ||
| from scos_actions.core.status_monitor import StatusMonitor |
There was a problem hiding this comment.
I think this import is no longer needed since the status_registrar instance of StatusMonitor was moved to scos_actions.core
| logger.debug("Initializing Signal Analyzer Monitor") | ||
| self._signal_analyzer = None | ||
|
|
||
| def register_signal_analyzer(self, sigan): |
There was a problem hiding this comment.
Suggest including a type hint here and on the property below to indicate that these expect/return instances of SignalAnalyzerInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a new register_signal_analyzer signal to allow signal analyzers to register themselves. In addition, this creates a new core module to allow for the creation of needed core components including the SignalAnalyzerMonitor ans StatusMonitor (moved from status module). Within the hardware module, a register_signal_analyzer handler is connected that uses the SignalAnalyzerMonitor to set the sigan. Currently, the SignalAnalyzerMonitor assumes that only one sigan will be registered and the result is that if multiple are registered, the last one to register will be set as the signal analyzer. In the future, this could be easily modified if there were a need to support multiple sigans. Finally, this increments the version to 8.0.0.