Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update PSD statistical detector set in SEA action #105

Merged
merged 12 commits into from
Jan 5, 2024
Merged

Update PSD statistical detector set in SEA action #105

merged 12 commits into from
Jan 5, 2024

Conversation

aromanielloNTIA
Copy link
Member

In the SEA action:

  • Reduce PSD frequency resolution to 80 kHz from 16 kHz (FFT length 175 down from 875)
  • Update detector set: add median and (25th, 75th, 90th, 95th, 99th, 99.9th, 99.99th) percentiles, detected per bin

@aromanielloNTIA aromanielloNTIA self-assigned this Dec 26, 2023
@aromanielloNTIA aromanielloNTIA marked this pull request as ready for review December 28, 2023 22:33
@dboulware dboulware self-requested a review January 4, 2024 16:35
dboulware
dboulware requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@dboulware dboulware left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good, but I think it should increase the version since these changes will break the old configs.

@aromanielloNTIA
Copy link
Member Author

Agreed, but left the version unchanged by this PR since we should bundle a release with other recent/ongoing PRs which will already bump the version. I can make this individually increment the version instead if you think that's better.

@dboulware dboulware merged commit 1eb6265 into master Jan 5, 2024
4 checks passed
@aromanielloNTIA aromanielloNTIA deleted the add-percentile-detector branch January 5, 2024 16:04
@aromanielloNTIA aromanielloNTIA mentioned this pull request Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dboulware dboulware dboulware approved these changes

Assignees

@aromanielloNTIA aromanielloNTIA

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aromanielloNTIA @dboulware