Diagnostics Update #101
Merged
Diagnostics Update #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… closed and 1 indicates it is open.
…configured to be 0 for closed and 1 for open.
aromanielloNTIA
requested changes
Dec 1, 2023
| lna_temp: Optional[float] = None | ||
| antenna_path_enabled: Optional[bool] = None | ||
| noise_diode_path_enabled: Optional = None |
There was a problem hiding this comment.
type annotation should be Optional[bool]
| if "power_monitor28v" in all_switch_status: | ||
| switch_diag["power_sensors"].append( | ||
| { | ||
| "name": "28v Monitor", |
There was a problem hiding this comment.
Suggest capitalizing "V" for Volts in all the power monitor diagnostics object names, e.g. "28V Monitor"
aromanielloNTIA
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modifies the diagnostics metadata and upgrades the preselector library version. Most of the changes are in the SPU object. Now the SPU contains sigan_powered, preselector_powered, humidity_sensors, temperature_sensors, power_sensors, door_closed, temperature_control_powered, heating, cooling, battery_backup, low_battery, battery_healthy, ups_healthy. This also moves the action_runtime into the computer diagnostics and changes the scos_uptime and scos_start to software_uptime and software_start. The acquire_sea_data_product actions has also been modified to look for specific states and sensors in the switches. If it finds them, it will add them to the appropriate metadata. The sea action has been modified to collect status on all switches and look for specific sensors and states. If they are not found they will not be added to the diagnostics.