Skip to content

Commit

Permalink
add plugin_name property to sigan iface
Browse files Browse the repository at this point in the history
  • Loading branch information
jhazentia committed Mar 8, 2024
1 parent ab657a9 commit c56da56
Show file tree
Hide file tree
Showing 3 changed files with 13 additions and 1 deletion.
2 changes: 1 addition & 1 deletion scos_actions/actions/acquire_sea_data_product.py
Original file line number Diff line number Diff line change
Expand Up @@ -794,7 +794,7 @@ def capture_diagnostics(
"scos_sensor_version": SCOS_SENSOR_GIT_TAG,
"scos_actions_version": SCOS_ACTIONS_VERSION,
"scos_sigan_plugin": ntia_diagnostics.ScosPlugin(
name="scos_tekrsa", version=self.sensor.signal_analyzer.plugin_version
name=self.sensor.signal_analyzer.plugin_name, version=self.sensor.signal_analyzer.plugin_version
),
"preselector_api_version": PRESELECTOR_API_VERSION,
"sigan_firmware_version": self.sensor.signal_analyzer.firmware_version,
Expand Down
6 changes: 6 additions & 0 deletions scos_actions/hardware/mocks/mock_sigan.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import numpy as np

from scos_actions import __version__ as SCOS_ACTIONS_VERSION
from scos_actions import __package__ as SCOS_ACTIONS_NAME
from scos_actions.calibration.calibration import Calibration
from scos_actions.hardware.sigan_iface import SignalAnalyzerInterface
from scos_actions.utils import get_datetime_str_now
Expand Down Expand Up @@ -65,6 +66,7 @@ def __init__(
self._capture_time = None
self._is_available = True
self._plugin_version = SCOS_ACTIONS_VERSION
self._plugin_name = SCOS_ACTIONS_NAME
self._firmware_version = "1.2.3"
self._api_version = "v1.2.3"

Expand All @@ -84,6 +86,10 @@ def is_available(self):
@property
def plugin_version(self):
return self._plugin_version

@property
def plugin_name(self) -> str:
return self._plugin_name

@property
def firmware_version(self):
Expand Down
6 changes: 6 additions & 0 deletions scos_actions/hardware/sigan_iface.py
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,12 @@ def plugin_version(self) -> str:
"""Returns the version of the SCOS plugin defining this interface."""
pass

@property
@abstractmethod
def plugin_name(self) -> str:
"""Returns the name of the SCOS plugin defining this interface."""
pass

@property
def firmware_version(self) -> str:
"""Returns the version of the signal analyzer firmware."""
Expand Down

0 comments on commit c56da56

Please sign in to comment.