Bnb/exo refactor plus #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bnb32
force-pushed
the
bnb/exo_refactor_plus
branch
7 times, most recently
from
57c9de8 to
f8affc0
Compare
bnb32
force-pushed
the
bnb/exo_refactor_plus
branch
from
f8affc0 to
e39bfdb
Compare
grantbuster
requested changes
Oct 12, 2023
sup3r/models/abstract.py
Outdated
| @@ -274,13 +268,10 @@ def _combine_fwp_output(self, hi_res, exogenous_data=None): | |||
| (n_obs, spatial_1, spatial_2, n_features) | |||
| (n_obs, spatial_1, spatial_2, n_temporal, n_features) | |||
| exogenous_data : dict | None | |||
| spatial models and temporal models split_step should be | ||
| len(spatial_models). If this is for a TemporalThenSpatial model | ||
| split_step should be len(temporal_models). | ||
| exogenous_data : dict |
bnb32
force-pushed
the
bnb/exo_refactor_plus
branch
from
6ef5591 to
53d8bc7
Compare
grantbuster
approved these changes
Oct 13, 2023
github-actions bot
pushed a commit
that referenced
this pull request
Oct 13, 2023
Bnb/exo refactor plus
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.