Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bespoke PC losses fix #521

Merged
merged 3 commits into from
Mar 17, 2025
Merged

Bespoke PC losses fix #521

merged 3 commits into from
Mar 17, 2025

Conversation

ppinchuk
Copy link
Collaborator

Previously, power curve losses were being applied twice in bespoke. This patch fixes the behavior to only adjust power curve once per wind power execution.

@ppinchuk ppinchuk added bugfix Fixes a bug p-high Priority: high topic-bespoke Issues/pull requests related to bespoke wind computation labels Mar 17, 2025
@ppinchuk ppinchuk added this to the FY25 SS milestone Mar 17, 2025
@ppinchuk ppinchuk self-assigned this Mar 17, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.66%. Comparing base (4125a9f) to head (014367b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
+ Coverage   87.61%   87.66%   +0.05%     
==========================================
  Files         121      121              
  Lines       18387    18405      +18     
==========================================
+ Hits        16109    16134      +25     
+ Misses       2278     2271       -7     
Flag Coverage Δ
unittests 87.66% <100.00%> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ppinchuk ppinchuk merged commit eb62992 into main Mar 17, 2025
14 checks passed
@ppinchuk ppinchuk deleted the pp/bespoke_pc_losses_fix branch March 17, 2025 20:14
github-actions bot pushed a commit that referenced this pull request Mar 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug p-high Priority: high topic-bespoke Issues/pull requests related to bespoke wind computation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants