Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icing losses to bespoke #519

Merged
merged 20 commits into from
Feb 24, 2025
Merged

Add icing losses to bespoke #519

merged 20 commits into from
Feb 24, 2025

Conversation

ppinchuk
Copy link
Collaborator

@ppinchuk ppinchuk commented Feb 24, 2025

Now that we officially support CT curve inputs, we can finally merge the icing losses for Bespoke branch. Thanks for authoring this @WilliamsTravis!

WilliamsTravis and others added 20 commits June 7, 2024 15:27
@ppinchuk ppinchuk added enhancement Update to logic or general code improvements p-low Priority: low topic-losses Issues/pull requests related to generation losses/curtailment topic-bespoke Issues/pull requests related to bespoke wind computation labels Feb 24, 2025
@ppinchuk ppinchuk added this to the FY25 SS milestone Feb 24, 2025
@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2025

Codecov Report

Attention: Patch coverage is 97.05882% with 1 line in your changes missing coverage. Please review.

Project coverage is 87.65%. Comparing base (1971309) to head (f2a9180).

Files with missing lines Patch % Lines
reV/bespoke/bespoke.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #519      +/-   ##
==========================================
+ Coverage   87.61%   87.65%   +0.04%     
==========================================
  Files         121      121              
  Lines       18382    18401      +19     
==========================================
+ Hits        16105    16130      +25     
+ Misses       2277     2271       -6     
Flag Coverage Δ
unittests 87.65% <97.05%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ppinchuk ppinchuk merged commit 373d4e7 into main Feb 24, 2025
14 checks passed
@ppinchuk ppinchuk deleted the tw/bespoke_icing branch February 24, 2025 20:51
github-actions bot pushed a commit that referenced this pull request Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Update to logic or general code improvements p-low Priority: low topic-bespoke Issues/pull requests related to bespoke wind computation topic-losses Issues/pull requests related to generation losses/curtailment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants