fixing str_replace call according to rename in rev #55
+3
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@grantbuster The mlclouds tests seem to failing bc the production model was made with tensorflow=2.8. Should we update the model or pin tensorflow? Phygnn would also need to be pinned in that case, I think. |
|
TF 2.8 is already pinned in mlclouds? |
Oh yeah, you're right. I was able to reproduce the error with tf=2.8 and phygnn=current, and resolved the error with phygnn=0.0.14. So maybe it has to do with phygnn? |
|
what version of phygnn was the mlclouds model produced with? fine to pin the phygnn version if that fixes things but that would surprise me because the phygnn requirements are pretty flexible. |
|
It was produced with version 0.0.14 but I'd rather not pin this either. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.