Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update isdigit, isalpha, and isalnum to handle Unicode characters #54

Merged
merged 2 commits into from
Mar 23, 2025

Conversation

sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Mar 21, 2025

Addresses issue #53

Windows debug build in VS 2022 with no assert errors
image

Copy link
Collaborator

@cpaulgilman cpaulgilman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix! Windows Debug works without assertion failure, and Linux Release works as expected. Note LK IDE in Linux shows unknown characters as question mark (?) while Windows (above) shows a random character. Screenshot from Linux Mint 21.1 Cinnamon:

image

@cpaulgilman
Copy link
Collaborator

cpaulgilman commented Mar 21, 2025

@sjanzou I added a commit so that the following LK script does not result in a debug assert error:

x = isdigit('');
outln(x);

Please change if there's a better way to do that.

@sjanzou
Copy link
Collaborator Author

sjanzou commented Mar 23, 2025

@sjanzou I added a commit so that the following LK script does not result in a debug assert error:

x = isdigit('');
outln(x);

Please change if there's a better way to do that.

Thanks for checking for null characters.

@sjanzou sjanzou merged commit 10ba5d2 into develop Mar 23, 2025
2 checks passed
@sjanzou sjanzou deleted the lk_53 branch March 23, 2025 07:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update isdigit, isalpha, and isalnum to handle Unicode without debug assertions
2 participants