[BUGFIX] Control setpoints and wind data set on FlorisModel
copied into ParFlorisModel
#997
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
One way of instantiating a
ParFlorisModel
is to pass in an instantiatedFlorisModel
. However, as is, if there are any control setpoints (yaw_angles
, ...) that had already been set on the instantiatedFlorisModel
, they were dropped on instantiation of theParFlorisModel
. Similarly,wind_data
was not copied over correctly.A workaround is to only
set()
control setpoints and wind data after instantiating theParFlorisModel
; however, this is not immediately obvious to the user. Instead, this PR fixes the bug. In particular, the following codeproduces
[[0. 0. 0.]]
andNone
prior to the bugfix; while producing[[20. 10. 0.]]
and<floris.wind_data.TimeSeries object at 0x12f93e9f0>
, as expected, with the fix.