Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update names of WindRose resampling methods #933

Merged
merged 5 commits into from
Jun 26, 2024

Conversation

paulf81
Copy link
Collaborator

@paulf81 paulf81 commented Jun 26, 2024

Update names of wind rose resampling functions

As discussed in #931, the function names for resampling aggregate and resample_by_interpolation would be clearer in their usage if they were renamed downsample and upsample. This PR implements that change, with matching changes to tests, examples and documentation. The old function names alias the new function names for backwards compatibility with v4.0.

Related issue

Discussion #931

Impacted areas of the software

wind_data.py

@paulf81 paulf81 self-assigned this Jun 26, 2024
@misi9170 misi9170 changed the title Feature/rename wind rose resampling Update names of wind rose resampling methods Jun 26, 2024
@misi9170 misi9170 changed the title Update names of wind rose resampling methods Update names of WindRose resampling methods Jun 26, 2024
@paulf81 paulf81 merged commit e1a25d7 into NREL:develop Jun 26, 2024
8 checks passed
@paulf81 paulf81 deleted the feature/rename_wind_rose_resampling branch June 26, 2024 21:58
@misi9170 misi9170 mentioned this pull request Jul 15, 2024
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants