-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to fix yaw to nominal wind direction #850
Allow to fix yaw to nominal wind direction #850
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't related to the changes in the current PR, but I'm having a hard time understanding what the UncertainFlorisModel does. For example, how are wind speed and TI resolution used? Does uncertainty get modeled for those variables in addition to wind direction? Also, do Gaussian weights get applied to the power at the wd_sample_points? I'd suggest some additional explanation in the class docstring.
floris/uncertain_floris_model.py
Outdated
direction? When False, | ||
the yaw angle is the same across the sampled wind directions. When True, the yaw | ||
angle is fixed to the nominal wind direction and so of offset by the negative of | ||
wind direction offset. Defaults to False. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This description is a little confusing to me. Could this say "When False, the yaw misalignment is the same across the sampled wind directions. When True, the turbine orientation is fixed to the nominal wind direction such that the yaw misalignment changes depending on the sampled wind direction."
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done!
Sorry, accidentally rerequested review from @rafmudaf, who had approved already. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra documentation looks good
Add fix_yaw_to_nominal_direction
This pull request re-includes the option in the UncertainFlorisModel to fix the yaws into the frame of the nominal wind direction. Currently for example, if yaw angle is 0, and wind direction is 270, uncertainty is computed over a range of wind direction while holding yaw = 0. This pull request adds the flag fix_yaw_to_nominal_direction, which changes the computations such that the yaw is modified to always be 0 relative to the nominal 270 degrees (so it would be +3 when checking 267 for nominal 270)
Specific changes: