-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drive layout optimizations using WindData objects #822
Conversation
floris/tools/optimization/layout_optimization/layout_optimization_boundary_grid.py
Outdated
Show resolved
Hide resolved
floris/tools/optimization/layout_optimization/layout_optimization_pyoptsparse.py
Outdated
Show resolved
Hide resolved
floris/tools/optimization/layout_optimization/layout_optimization_base.py
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @paulf81, the WindData additions all look good here.
I merged |
Merged v4 back in again |
|
||
from ....logging_manager import LoggingManager | ||
|
||
|
||
class LayoutOptimization(LoggingManager): | ||
def __init__(self, fi, boundaries, min_dist=None, freq=None, enable_geometric_yaw=False): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does this mean that, if the user would like to provide a weighting to different wind speed bins; they must provide a wind_data
object (whereas if they want to use uniform weighting, just supplying fi
will suffice)?
Could we instead leave thefreq
option, which will be ignored if wind_data
is None
, but which otherwise will be used in the creation of the TimeSeries
object in LayoutOptimization.__init__()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@misi9170 let's chat about this one tomorrow,
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok good point @misi9170 , as discussed changing wind_data to required input to avoid supplying a use case no one is likely to want but could get accidentally
Drive layout optimizations using WindData objects
This pull request reorients the layout optimization classes to accept WindData objects (WindRose or TimeSeries), in place of freq tables, in order to facilitate allowing change of optimization from maximizing AEP to maximizing other quantities such as revenue. Changing to passing the WindData objects facilitates this because these objects hold the value per bin (WindRose) or as a time series (TimeSeries).
(Note this will appear to be many changes at first since built off of #819 ) but once that PR is merged, this will look much simpler
Related issue
#779