Remove small variations in above rated power #784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@paulf81 The changes here wouldn't be used in the regression tests since they aren't defined in the conftest file. For consistency, we should maintain the same NREL 5MW definition in conftest.py. |
Done! |
Nice to see no change to reg test results, although I guess those mostly (possibly all) use below-rated wind speeds. Anyway, no issue there. |
rafmudaf
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove small variations in above rated power
Small variations in power (say 0.01 kW with power at 5000 kW) have very small impact on power and are probably simply coming from minor numerical variations in the code used to derive them. However, they can create useless (and possibly significant) gradients for different optimization strategies. With the new power-based input yaml implemented in #765 it's easy to ensure region 3 power is perfectly flat. This pull request adjusts the 3 turbine yaml files included to have flat power above region 3.
Related Issues
This should firmly address Issue #554 as well as #583
Other notes
Change is quite small and didn't require updating any unit or regression tests