Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update default parameters for the Empirical Gaussian model #723

Merged
merged 4 commits into from
Oct 26, 2023

Conversation

misi9170
Copy link
Collaborator

Description

When the Empirical Gaussian model was implemented, not a lot of attention was paid to the default parameter settings because it was intended to be tuned to match the user's SCADA records. While that intention is still the case, we have now had a chance to provide a rough tuning to various SCADA records and can provide an updated default set of parameters.

Note that we may update the defaults again in future to provide different parameter sets for, for example, onshore and offshore farms, daytime and nighttime boundary layers, etc.

Affected code

  • examples
    • Main Empirical Gaussian example input file inputs/emgauss.yaml
    • Secondary Empirical Gaussian examples inputs for floating under inputs_floating/
    • Examples 26, 27, and 29 (minor updates to improve understanding with new defaults)
  • floris/simulation
    • attrs default values in wake_deflection/empirical_gauss.py and wake_velocity/empirical_gauss.py

Functional changes

  • No changes to main source code
  • Examples 25, 26, 27, and 29 now produce slightly different results
  • Tests pass.

@misi9170 misi9170 marked this pull request as draft October 24, 2023 23:42
@misi9170
Copy link
Collaborator Author

misi9170 commented Oct 24, 2023

Converting to draft until @paulf81 has had a chance to look at this. If you're happy, feel free to convert back to "Ready for review"

@misi9170 misi9170 added floating-turbine examples Changes to FLORIS examples labels Oct 24, 2023
@rafmudaf
Copy link
Collaborator

I expected that the regression tests would fail after changing the default model parameters. Do you have a thought why they didn't @misi9170?

@misi9170
Copy link
Collaborator Author

I expected that the regression tests would fail after changing the default model parameters. Do you have a thought why they didn't @misi9170?

@rafmudaf Thank you for pointing this out. As we discussed, this was caused by my overlooking the parameter values in conftest.py. I have now updated those (which initially causes the regression test to fail), and then updated the comparison outputs in the regression tests so that they're now passing once again.

@rafmudaf rafmudaf added this to the v3.5 milestone Oct 26, 2023
@misi9170 misi9170 marked this pull request as ready for review October 26, 2023 19:27
@misi9170 misi9170 merged commit 6c3ddb4 into NREL:develop Oct 26, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
examples Changes to FLORIS examples
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants