Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[magnum]: remove deprecated functionality #95

Merged
merged 1 commit into from
Sep 24, 2020
Merged

Conversation

costashatz
Copy link
Member

In latest magnum master, some functionalities are deprecated. This PR uses the newest version of Magnum. Creating this PR to ping @jbmouret, @dalinel to update Magnum before I merge.

@costashatz
Copy link
Member Author

@jbmouret @dalinel @Aneoshun let me know if you had any issues. I'll merge if you integrated this in your pipeline..

@Aneoshun
Copy link
Contributor

Hi @costashatz !

I am following carefully your updates (I like the new sensor API).
Right now, all our pipelines are pinned on a commit from January'20. I am planning a migration to a more recent version of robot_dart + magnum in the next few weeks (to be sync with the arrival of new PhD students). I will test all your latest changes at that point. Hopefully, this will coincide with the first release candidate of Robot_dart 1.0.

@costashatz costashatz added this to the RobotDART 1.0.0 milestone Sep 22, 2020
@costashatz
Copy link
Member Author

Hopefully, this will coincide with the first release candidate of Robot_dart 1.0.

Hopefully this will be soon! ;)

@jbmouret @dalinel @Aneoshun let me know if you had any issues. I'll merge if you integrated this in your pipeline..

@jbmouret @dalinel I will merge this, and please pull the latest magnum source (and all deps) to not break your setups.

@costashatz costashatz merged commit e43ed9c into master Sep 24, 2020
@costashatz costashatz deleted the magnum_deprecated branch September 24, 2020 19:15
costashatz added a commit that referenced this pull request Dec 8, 2021
[magnum]: remove deprecated functionality
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants