Make boost.process optional (but make it possible to record videos) #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why do we need boost.process if we can do it without it? Is there any real need for boost process? |
|
The boost.process code is much more elegant, portable and I think robust. We already have a dependency to boost, so this is essentially "for free" (except on old Ubuntu). |
|
Merging.. |
costashatz
added a commit
that referenced
this pull request
Dec 8, 2021
Make boost.process optional (but make it possible to record videos)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I implemented it in the "good old way" because the unbuntu that is on the official Talos dev dockers/PC (16.x) does not have the right boost version.
We might remove this in the future once everybody has a a recent boost.