-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ghost robots and other visualizations #57
Conversation
At the moment we can clone robots in I am also thinking to make it possible to select whether a camera should render ghost robots and other visualizations. For example, we might want the main camera to display the ghost robots/visualizations for inspection, but the sensor cameras to not display them. My thoughts are as follows: Do we really need this? I mean we would usually use the main camera only when debugging. When running the learning algorithms or other simulation, it will be rare that we would want a gui visualization as this will slow things down. So one can create 2 executables with defines: one for inspection and another for running without the GUI. On the other hand, being able to choose which objects get displayed and which not might be useful in other cases as well. @jbmouret @dalinel @PedroDesRobots let me know what you think.. I will add the rest of the visualizations as well (spheres, cubes, etc.).. |
On our side, we are not using cameras as sensors, so this does not make any difference for now. But the idea of 'ghosts' is that they do not appear on sensors, so we might want to keep this in mind anyway. |
It was much easier to do than I thought! I pushed the fix. No we can choose whether we want to draw ghosts objects, both in the main camera and every other sensor.. |
…ry similar to robot.ghost_clone
@jbmouret @dalinel @PedroDesRobots this should finished. I will not include the ConvexHull in this iteration... Let me know if I can merge.. |
It is ok for me ! |
@Aneoshun @Lookatator pinging you in case this is breaking your code (we are breaking slightly the GUI API).. |
Hey, that's a fantastic feature! Thanks. |
Great! Thanks for the information!
What problems are you facing with DART? Or you meant tasks? |
The "memory leak" fix introduced last week causes some issues in thread safety with random segfaults during sferes experiments. |
@Aneoshun thank you for letting us know. Thankfully we do not really depend on the latest master for robot_dart, but it's good to know. Can you make a separate issue for this? Thanks again! |
A separate issue, where? On Robot_dart, just to keep track of the issue in dart? |
yes thank you! |
done |
This PR fixes #40..
Still WIP..This will break the GUI API slightly again..