Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ghost robots and other visualizations #57

Merged
merged 3 commits into from
May 15, 2020
Merged

Conversation

costashatz
Copy link
Member

@costashatz costashatz commented May 15, 2020

This PR fixes #40.. Still WIP.. This will break the GUI API slightly again..

@costashatz
Copy link
Member Author

At the moment we can clone robots in ghost mode: the user can choose the color of the ghost robot and ghost robots have no shadows. Here's an example:
image

I am also thinking to make it possible to select whether a camera should render ghost robots and other visualizations. For example, we might want the main camera to display the ghost robots/visualizations for inspection, but the sensor cameras to not display them.

My thoughts are as follows:

Do we really need this? I mean we would usually use the main camera only when debugging. When running the learning algorithms or other simulation, it will be rare that we would want a gui visualization as this will slow things down. So one can create 2 executables with defines: one for inspection and another for running without the GUI. On the other hand, being able to choose which objects get displayed and which not might be useful in other cases as well.

@jbmouret @dalinel @PedroDesRobots let me know what you think.. I will add the rest of the visualizations as well (spheres, cubes, etc.)..

@costashatz costashatz self-assigned this May 15, 2020
@costashatz costashatz added this to the RobotDART 1.0.0 milestone May 15, 2020
@jbmouret
Copy link
Collaborator

On our side, we are not using cameras as sensors, so this does not make any difference for now. But the idea of 'ghosts' is that they do not appear on sensors, so we might want to keep this in mind anyway.

@costashatz
Copy link
Member Author

But the idea of 'ghosts' is that they do not appear on sensors

It was much easier to do than I thought! I pushed the fix. No we can choose whether we want to draw ghosts objects, both in the main camera and every other sensor..

@costashatz
Copy link
Member Author

@jbmouret @dalinel @PedroDesRobots this should finished. I will not include the ConvexHull in this iteration... Let me know if I can merge..

@dalinel
Copy link
Contributor

dalinel commented May 15, 2020

It is ok for me !

@costashatz
Copy link
Member Author

@Aneoshun @Lookatator pinging you in case this is breaking your code (we are breaking slightly the GUI API)..

@Aneoshun
Copy link
Contributor

Hey, that's a fantastic feature! Thanks.
If it works for you, you can merge. We have pined the commit SHA of all the modules used and we will remain a bit behind master, while our current problems with dart are not solved.

@costashatz
Copy link
Member Author

Hey, that's a fantastic feature! Thanks.
If it works for you, you can merge. We have pined the commit SHA of all the modules used and we will remain a bit behind master

Great! Thanks for the information!

while our current problems with dart are not solved

What problems are you facing with DART? Or you meant tasks?

@costashatz costashatz merged commit 0249a1b into master May 15, 2020
@costashatz costashatz deleted the ghost_viz branch May 15, 2020 21:31
@Aneoshun
Copy link
Contributor

The "memory leak" fix introduced last week causes some issues in thread safety with random segfaults during sferes experiments.
dartsim/dart#1468

@costashatz
Copy link
Member Author

The "memory leak" fix introduced last week causes some issues in thread safety with random segfaults during sferes experiments.
dartsim/dart#1468

@Aneoshun thank you for letting us know. Thankfully we do not really depend on the latest master for robot_dart, but it's good to know. Can you make a separate issue for this? Thanks again!

@Aneoshun
Copy link
Contributor

A separate issue, where? On Robot_dart, just to keep track of the issue in dart?

@costashatz
Copy link
Member Author

On Robot_dart, just to keep track of the issue in dart?

yes thank you!

@Aneoshun
Copy link
Contributor

done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add API for easily adding markers/ghost robots and other visualizations
4 participants