Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update icub.urdf #188

Merged
merged 1 commit into from
Sep 9, 2022
Merged

update icub.urdf #188

merged 1 commit into from
Sep 9, 2022

Conversation

olivierrochel-inria
Copy link
Contributor

Fix limits to match values in xml files (motor control conf) on the robot, and/or documentation when available.
Change links/joints names to match the documentation and the convention used in other (official) icub models.
@jbmouret
Copy link
Collaborator

jbmouret commented Sep 5, 2022

Thanks. I will check everything. I think we should rename the robot as icub_nancy01.urdf as this is very specific to our robot. What do you think?

@costashatz costashatz added this to the RobotDART 1.0.0 milestone Sep 5, 2022
@costashatz
Copy link
Member

I think we should rename the robot as icub_nancy01.urdf as this is very specific to our robot. What do you think?

I agree although the current iCub.urdf was built around the Nancy robot. So we could rename the robot as a whole? Or just add a note in the docs/files?

@jbmouret
Copy link
Collaborator

jbmouret commented Sep 5, 2022

besides this naming question, I think we should merge asap.

@olivierrochel-inria
Copy link
Contributor Author

I'd 👍 the "note in the docs/files" option: people who own an icub know there's no "standard" icub so they'll look for that piece of information anyway, for the others that's not critical. I'm not against renaming the robot though if you think it's clearer that way.

@costashatz
Copy link
Member

I think we should merge.. No? @olivierrochel-inria @jbmouret ?

@olivierrochel-inria
Copy link
Contributor Author

I think we can merge, yes. As for the name the doc says "There are currently 42 iCUbs in the world, and many versions. [...] Our model is close to the Inria's iCub" so the information is there, we can see later if it needs to be made more explicit.

@jbmouret
Copy link
Collaborator

jbmouret commented Sep 9, 2022

Yes good for me.

@costashatz costashatz merged commit 7899ab3 into master Sep 9, 2022
@costashatz costashatz deleted the icub_model_update branch September 9, 2022 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants