Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix joints limits to match values in xml files (motor control configuration) on the robot, and/or documentation when available.
This makes the control more consistent between the simulation and (at least) one real robot, the one at Inria Nancy. The new values have been chosen to be compatible with the ones on the robot in Nancy, and the documentation here https://icub-tech-iit.github.io/documentation/icub_kinematics/icub-joints-limits/icub-joints-limits/
Change links/joints names to match the documentation and the convention used in other (official) icub models.
The names have been changed to follow the official naming convention: https://icub-tech-iit.github.io/documentation/icub_kinematics/icub-model-naming-conventions/icub-model-naming-conventions/
Only 2 joints have been renamed:
l_elbow_joint
→l_elbow
andr_elbow_joint
→r_elbow
(other joints don't have the_joint
suffix).Some links have been renamed to match the official doc, which sometimes results in less readable name (eg l_hip_pitch_link becomes l_hip_1 ).