Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tiago]: Fix initial z location that ends up in collision #170

Merged
merged 1 commit into from
Feb 10, 2022

Conversation

costashatz
Copy link
Member

No description provided.

@costashatz costashatz added this to the RobotDART 1.0.0 milestone Feb 10, 2022
@costashatz costashatz self-assigned this Feb 10, 2022
@jbmouret
Copy link
Collaborator

I do not like to see robots falling (this is why it's good to have the robot classes ;) ).... but if I use .009 instead of 0.01, it probably collides... (slow?).

At any rate, a big source of slowness is the position of the torso_lift_joint: I think that a p=0, it collides somewhere (floor? self-collision). Things do not work with 0 (in the example, we move it with a sin(x), therefore it does not stay at 0 for long).

Also, we (I) should make a dart-collision version so that we do not have to use FCL...

@costashatz
Copy link
Member Author

I do not like to see robots falling (this is why it's good to have the robot classes ;) ).... but if I use .009 instead of 0.01, it probably collides... (slow?).

If it is slow, yes it collides. I just tried and with 0.009 it is slow (this means that it collides). Also with 0.01 we do not see it falling.

At any rate, a big source of slowness is the position of the torso_lift_joint: I think that a p=0, it collides somewhere (floor? self-collision). Things do not work with 0 (in the example, we move it with a sin(x), therefore it does not stay at 0 for long).

For me it runs quite fast.

Also, we (I) should make a dart-collision version so that we do not have to use FCL...

Why not.. I plan on working on making Tiago movable (steering) because I need this for a few projects..

@costashatz
Copy link
Member Author

@jbmouret so should I merge this?

@costashatz costashatz merged commit 3755d20 into master Feb 10, 2022
@costashatz costashatz deleted the fix_tiago branch February 10, 2022 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants