Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Utheque: URDF-theque (library of URDFs) #166

Merged
merged 23 commits into from
Jan 24, 2022
Merged

Utheque: URDF-theque (library of URDFs) #166

merged 23 commits into from
Jan 24, 2022

Conversation

jbmouret
Copy link
Collaborator

Objective: make it easy to use the well-maintained URDF files without robot_dart (e.g., on a real robot, which does not have assimp, dart, etc.).

  • We install the URDF files in $PREFIX/share/utheque instead of $PREFIX/share/robot_dart so that it makes more sense to use the same URDF if we do not care about robot_dart (e.g., for controllers)
  • We can install the URDF even if robot_dart does not compile
  • There is a small header-only library utheque/utheque.hpp that makes it easy to get a URDF from the library (e.g., in a controller)

TODO: option to deactivate explicitly robot_dart

@costashatz costashatz added this to the RobotDART 1.0.0 milestone Jan 21, 2022
wscript Outdated Show resolved Hide resolved
wscript Outdated Show resolved Hide resolved
wscript Show resolved Hide resolved
Copy link
Member

@costashatz costashatz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is nice! See a few minor comments. Once they are done, I will format the code and merge! Thanks!

@jbmouret
Copy link
Collaborator Author

Please note that I did not try the CMake integration yet.

@costashatz
Copy link
Member

@jbmouret CMake integration should be working now. I tried on my PC and added a test in the CI. Check also in your Mac. If it works there as well, we should be ready to merge...

@costashatz costashatz merged commit cfc406c into master Jan 24, 2022
@costashatz costashatz deleted the utheque branch January 24, 2022 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants