Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a robot pool #100

Merged
merged 7 commits into from
Sep 28, 2020
Merged

Create a robot pool #100

merged 7 commits into from
Sep 28, 2020

Conversation

jbmouret
Copy link
Collaborator

This is useful when we use robot_dart in many threads and we want to avoid parsing new robots from scratch.

Fix #99

@costashatz costashatz added this to the RobotDART 1.0.0 milestone Sep 26, 2020
@costashatz
Copy link
Member

@jbmouret thanks for this. I pushed a fix for a missing linking flag, but I have one bigger concern. What happens if we want to use to use two robots (and thus there is a need for 2 robot pools with different robots)? The way it is now, this is not possible..

@jbmouret
Copy link
Collaborator Author

Good question:

  • we can choose to not cover this case
  • we can suppress the singleton access (it is handy but the user can do a global variable instead or link instances)

I would vote for the second case.

@costashatz
Copy link
Member

I would vote for the second case.

Agree!

@costashatz
Copy link
Member

Merging...

@costashatz costashatz merged commit 705c9c4 into master Sep 28, 2020
@costashatz costashatz deleted the robot_pool branch September 28, 2020 13:24
costashatz added a commit that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Include a clone pool
2 participants