[production/RRFS.v1]Fixes for REFS restart reproducibility and crash under DEBUG#90
Conversation
|
@JiliDong-NOAA Have you heard anything about this one? Wondering if it might be a good idea to create the associated UFS WM and UFSATM PRs so it has more visibility. |
Not yet. I was hoping to create single UFSATM and WM PRs by including all changes necessary after submodule components getting merged first. @pjpegion @ClaraDraper-NOAA @barlage could you review this PR when you have time? RRFSv1 implementation is approaching and we have a code handoff date as Oct. 31. |
|
@pjpegion I'm hoping at long last to get this change merged into production/RRFS.v1. Can you review/approve? Thanks! |
|
Thanks @pjpegion Can you merge it? I don't seem to have that permission for this repository. |
|
@MatthewPyle-NOAA @jkbk2004 is the code manager. |
|
@jkbk2004 Could we get your help to merge this one? Thanks! |
This PR addresses:
The issues are related to LSM-SPP. It appears that LSM-SPP perturbations were added to the whole domain without masking out the water/ice points. This caused:
Temporary patches were added to fix these crashes when running REFS under DEBUG. Could we have @ClaraDraper-NOAA and @barlage review these changes in lndp_apply_perts.F90? A more general question: should water/ice points be masked out when applying LSM-SPP when calling lndp_apply_perts or am I missing something here?
Fixes issue #92