Skip to content

Bring in nco DEBUG flag change for ops#86

Merged
jkbk2004 merged 4 commits into
NOAA-PSL:masterfrom
BrianCurtis-NOAA:nco_debug_changes
Dec 3, 2025
Merged

Bring in nco DEBUG flag change for ops#86
jkbk2004 merged 4 commits into
NOAA-PSL:masterfrom
BrianCurtis-NOAA:nco_debug_changes

Conversation

@BrianCurtis-NOAA
Copy link
Copy Markdown
Contributor

Bring in NCO DEBUG flag change for ops

The following flags will be added for DEBUG builds: -check all -check noarg_temp_created -ftrapuv

Two are required by NCO: -check all -ftrapuv
One will drastically reduce build output file size: -check noarg_temp_created

I've tested the build on the UFSWM. I will run the full UFSWM RT suite soon to ensure the build change does not impact results. I do not anticipate any changes.

@BrianCurtis-NOAA
Copy link
Copy Markdown
Contributor Author

Could a CM look over and give preliminary approval for the code changes. This is a requirement for UFSWM.

@gspetro-NOAA
Copy link
Copy Markdown

@pjpegion Could we get this subcomponent PR reviewed so that it's ready to go when we begin to process WM PR #2789?

@BrianCurtis-NOAA
Copy link
Copy Markdown
Contributor Author

Could I get an approval here that the code changes look OK and work in any testing you do?

@pjpegion
Copy link
Copy Markdown
Collaborator

pjpegion commented Dec 1, 2025

I approve the change, but there is no separate CI/CD tests for the stochastic physics repo yet.

@FernandoAndrade-NOAA
Copy link
Copy Markdown
Collaborator

FernandoAndrade-NOAA commented Dec 3, 2025

Testing for #2789 is complete, please continue with merging, thank you.

@jkbk2004 jkbk2004 merged commit ae192f1 into NOAA-PSL:master Dec 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants