Add if(allocated) checks to avoid segfaults#82
Merged
Conversation
…physics_ocn in stochastic_physics.F90 Fix segfault from attempt to use pointer SKEB_WTS when it is not associated with a target
Collaborator
|
I recommend splitting the if (pert_epbl .OR. do_ocnsppt) then block to be: allocate(tmp_wts(gis_stochy_ocn%nx, gis_stochy_ocn%ny)) |
… in stochastic_physics.F90
Contributor
Author
|
@pjpegion Is this what you mean, to split the options? |
14 tasks
jkbk2004
added a commit
that referenced
this pull request
May 1, 2025
(PLATFORM-1077) Adding CI/CD capabilities and Unit Tests + Add if(allocated) checks to avoid segfaults #82
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Code currently fills sppt_wts and skeb_wts whether or not associated with a target or allocated in MOM6. This leads to a segmentation fault in a UFS regression test (see ufs-community/ufs-weather-model#2711)
Protect by checking whether allocated first