Skip to content

Fix uninitialized min_rand variable in Thompson MP when using SPP #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pjpegion merged 2 commits into from
Apr 20, 2022
Merged

Fix uninitialized min_rand variable in Thompson MP when using SPP #57

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c94435
Add spp_stddev_cutoff as a variable to pass to CCPP.
JeffBeck-NOAA Apr 5, 2022
6922d73
Reorder SPP variables.
JeffBeck-NOAA Apr 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion stochastic_physics.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ subroutine init_stochastic_physics(levs, blksz, dtp, sppt_amp, input_nml_file_in
xlon,xlat, &
do_sppt_in, do_shum_in, do_skeb_in, lndp_type_in, n_var_lndp_in, use_zmtnblck_out, skeb_npass_out, &
lndp_var_list_out, lndp_prt_list_out, &
n_var_spp_in, spp_var_list_out, spp_prt_list_out, do_spp_in, &
n_var_spp_in, spp_var_list_out, spp_prt_list_out, spp_stddev_cutoff_out, do_spp_in, &
ak, bk, nthreads, mpiroot, mpicomm, iret)
!\callgraph
!use stochy_internal_state_moa
Expand Down Expand Up @@ -58,6 +58,7 @@ subroutine init_stochastic_physics(levs, blksz, dtp, sppt_amp, input_nml_file_in
real(kind=kind_dbl_prec), dimension(:), intent(out) :: lndp_prt_list_out
character(len=3), dimension(:), intent(out) :: spp_var_list_out
real(kind=kind_dbl_prec), dimension(:), intent(out) :: spp_prt_list_out
real(kind=kind_dbl_prec), dimension(:), intent(out) :: spp_stddev_cutoff_out


! Local variables
Expand Down Expand Up @@ -142,6 +143,7 @@ subroutine init_stochastic_physics(levs, blksz, dtp, sppt_amp, input_nml_file_in
if (n_var_spp>0) then
spp_var_list_out=spp_var_list(1:n_var_spp)
spp_prt_list_out=spp_prt_list(1:n_var_spp)
spp_stddev_cutoff_out=spp_stddev_cutoff(1:n_var_spp)
endif
if ( (.NOT. do_sppt) .AND. (.NOT. do_shum) .AND. (.NOT. do_skeb) .AND. (lndp_type==0) .AND. (.NOT. do_spp)) return
allocate(sl(levs))
Expand Down