fix restart logic when warm starting without CA restart and fix unit tests#50
Merged
Merged
Conversation
lisa-bengtsson
approved these changes
Dec 13, 2021
Collaborator
lisa-bengtsson
left a comment
lisa-bengtsson
left a comment
There was a problem hiding this comment.
Looks good to me, thanks
27 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PR fixes issue ufs-community/ufs-weather-model#955, where running with CA active either crashed in debug mode, or gave bad answers in production mode when warm starting the model, and not having CA restarts available.