add finalize subroutine for stochastic physics#32
Conversation
lisa-bengtsson
left a comment
There was a problem hiding this comment.
Looks good to me.
|
I would strongly suggest adding
do:
This better protects the code from possible and difficult to chase segmentation faults in the future -- at least based on my experience. |
|
@HenryWinterbottom-NOAA good point, I thought about doing it, but was just lazy. |
|
@pjpegion If you are planning to do it, just send me a note (or submit a new PR) and I am happy to approve. |
|
@HenryWinterbottom-NOAA I added the if (allocated()) conditionals |
HenryRWinterbottom
left a comment
There was a problem hiding this comment.
Thank you @pjpegion.
Approved.
climbfuji
left a comment
There was a problem hiding this comment.
The PR looks okay; there are several places where a comment line
! Copy blocked data into contiguous arrays; no need to copy weights in (intent(out))
was moved around to places where it doesn't belong. I recommend removing or changing them, but certainly not a show stopper.
I am currently creating new baselines on cheyenne.intel, cheyenne.gnu and gaea.intel. The new baseline date tag will be 20201127, please update RTPWD in rt.sh accordingly.
|
Looks like the changes you are suggesting are for the fv3atm PR. |
Yes, sorry. |
This a new feature to add a finalize subroutine to deallocate array at the end of a run. Associated with PRs
NOAA-EMC/ufsatm#199 and
ufs-community/ufs-weather-model#278